-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SSR/Next Server Actions Support #528
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 84.55% 90.79% +6.23%
==========================================
Files 9 25 +16
Lines 395 728 +333
Branches 109 180 +71
==========================================
+ Hits 334 661 +327
- Misses 52 62 +10
+ Partials 9 5 -4 ☔ View full report in Codecov by Sentry. |
@crutchcorn I think I'm a bit closer to figuring out the types problem. Firstly, the vue examples started failing on this commit: Removing I don't really know what to make of this, but I hope it gives a bit more direction. I'm going to submit a few tweaks on main that may or may not help out. |
# Conflicts: # pnpm-lock.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Here's my review, only small stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
* chore: Update CI versions of node and pnpm (#538) * Update node and pnpm for CI * Update concurrency and run conditions * docs(CONTRIBUTING.md): add instructions for previewing the docs locally (#537) * chore: Update to Nx v17 (#539) * Update CI run condition * Update to Nx v17 * Attempt to fix scripts * Fully utilise Nx for PR workflow * chore: Use updated `publish.js` script (#540) * Initial rename and copy * Update relevant packages * Remove ts-node * Mark root as ESM * Move getTsupConfig * Remove eslint-plugin-compat * Make codesandbox run Node 18 * chore: Add missing command to CI workflow (#541) * chore: Enable Nx distributed caching (#542) * chore: Update prettier config (#543) * Update prettier config * Run format * Update gitignore --------- Co-authored-by: fuko <[email protected]>
This PR improves on our SSR story by implementing many of the ideas outlined in #480
IE; we now support Next/React Server Actions like so:
To do this, we've implemented:
Working Remix demo(Need help with this, not blocking)transform
API in coremergeForm
APIuseTransform
API in React