-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Workspace fixes #533
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes overall! Let's solve these two problems before moving forward
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
==========================================
+ Coverage 84.55% 93.49% +8.94%
==========================================
Files 9 21 +12
Lines 395 646 +251
Branches 109 156 +47
==========================================
+ Hits 334 604 +270
+ Misses 52 39 -13
+ Partials 9 3 -6 ☔ View full report in Codecov by Sentry. |
These are all changes taken from my work in the
tanstack/query
repo. Sorry they're kind of all over the place - the commit descriptions are a fairly good changelog.There's a few more things that could be tightened up and might help identify the bug in #528 , but I thought I'd be incremental and submit these changes first.