Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Workspace fixes #533

Merged
merged 15 commits into from
Dec 28, 2023
Merged

chore: Workspace fixes #533

merged 15 commits into from
Dec 28, 2023

Conversation

lachlancollins
Copy link
Member

These are all changes taken from my work in the tanstack/query repo. Sorry they're kind of all over the place - the commit descriptions are a fairly good changelog.

There's a few more things that could be tightened up and might help identify the bug in #528 , but I thought I'd be incremental and submit these changes first.

Copy link

codesandbox-ci bot commented Dec 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes overall! Let's solve these two problems before moving forward

package.json Show resolved Hide resolved
examples/vue/valibot/package.json Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c2f9957) 84.55% compared to head (cd9e726) 93.49%.
Report is 93 commits behind head on main.

Files Patch % Lines
packages/form-core/src/FormApi.ts 93.10% 8 Missing ⚠️
packages/form-core/src/FieldApi.ts 96.42% 3 Missing ⚠️
packages/form-core/src/utils.ts 96.07% 2 Missing ⚠️
packages/react-form/src/useField.tsx 75.00% 2 Missing ⚠️
packages/solid-form/src/createField.tsx 96.55% 1 Missing ⚠️
packages/solid-form/src/createForm.tsx 92.30% 1 Missing ⚠️
packages/solid-form/src/formContext.ts 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   84.55%   93.49%   +8.94%     
==========================================
  Files           9       21      +12     
  Lines         395      646     +251     
  Branches      109      156      +47     
==========================================
+ Hits          334      604     +270     
+ Misses         52       39      -13     
+ Partials        9        3       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 250a7fe into TanStack:main Dec 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants