Skip to content

feat: add configurable server list for ping updates #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikafly144 wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −4
Open

feat: add configurable server list for ping updates #412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
815a396
feat: add configurable server list for ping updates
ikafly144 Mar 7, 2026
26fb5be
feat: refine server filtering for online player count in ping updates
ikafly144 Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...y/src/main/kotlin/org/sayandev/sayanvanish/velocity/feature/features/FeatureUpdatePing.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,35 @@ package org.sayandev.sayanvanish.velocity.feature.features
import com.velocitypowered.api.event.Subscribe
import com.velocitypowered.api.event.proxy.ProxyPingEvent
import com.velocitypowered.api.proxy.server.ServerPing
import org.sayandev.sayanvanish.api.feature.Configurable
import org.sayandev.sayanvanish.api.feature.RegisteredFeature
import org.sayandev.sayanvanish.velocity.api.SayanVanishVelocityAPI
import org.sayandev.sayanvanish.velocity.feature.ListenedFeature
import org.spongepowered.configurate.objectmapping.ConfigSerializable
import org.spongepowered.configurate.objectmapping.meta.Comment
import kotlin.jvm.optionals.getOrNull

@RegisteredFeature
@ConfigSerializable
class FeatureUpdatePing : ListenedFeature("update_ping") {
class FeatureUpdatePing(
@Comment("List of server names whose players are counted toward the online player count. If empty, players from all servers will be counted.")
@Configurable val servers: List<String> = emptyList()
) : ListenedFeature("update_ping") {

@Subscribe
fun onProxyPing(event: ProxyPingEvent) {
if (!isActive()) return
val pingPlayers = event.ping.players.getOrNull() ?: return
val vanishedOnlineUsers = SayanVanishVelocityAPI.getInstance().database.getUsers().filter { user -> user.isVanished && user.isOnline }
val vanishedOnlineUsersNames = vanishedOnlineUsers.map { vanishUser -> vanishUser.username }
val vanishedOnlineUsers = SayanVanishVelocityAPI.getInstance().database.getUsers().filter { user -> user.isVanished && user.isOnline && (servers.isEmpty() || user.serverId in servers) }
val vanishedOnlineUsersNames = vanishedOnlineUsers.map { vanishUser -> vanishUser.username }.toSet()
val nonVanishedPlayersCount = SayanVanishVelocityAPI.getInstance().database.getBasicUsers(true).filter { basicUser ->
!vanishedOnlineUsersNames.contains(basicUser.username)
(servers.isEmpty() || basicUser.serverId in servers) &&
!vanishedOnlineUsersNames.contains(basicUser.username)
}.size
val nonVanishedPlayersSample = pingPlayers.sample.filter { pingPlayer ->
!vanishedOnlineUsersNames.contains(pingPlayer.name)
}

event.ping = event.ping
.asBuilder()
.onlinePlayers(nonVanishedPlayersCount)
Expand Down