feat: add configurable server list for ping updates#412
Open
ikafly144 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable servers list to the FeatureUpdatePing feature in the Velocity proxy module. When configured, only players from the specified servers are counted toward the online player count displayed in the server ping response. This is motivated by avoiding conflicts with external MOTD plugins when using the SayanVanish plugin.
Changes:
- Added a
serversconstructor parameter toFeatureUpdatePingwith@Configurableand@Commentannotations, allowing server admins to specify which backend servers should be counted. - Added filtering logic in the
onProxyPinghandler to count only players on the configured servers when the list is non-empty. - Updated the
onlinePlayersvalue in the ping builder to use the filtered count.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the servers counted towards the online players in the server ping configurable. The main motivation for this change is to avoid conflicts with the SayanVanish plugin, which typically occur when trying to implement this feature via external MOTD plugins.