Skip to content

Address the 18 November v0.9.0 feedback: project_save, provisioning recovery, Unified alarms - #311

Merged
Sparkz400 merged 1 commit into
mainfrom
claude/v090-p4-feedback
Nov 18, 2026
Merged

Sparkz400 merged 1 commit into
mainfrom
claude/v090-p4-feedback

Conversation

@Sparkz400

Copy link
Copy Markdown
Owner

Change

A user ran the 12 November engineering bundle against a protected scratch CPU on PLCSIM Advanced V8 and reported traps and misleading results. Each item is recorded in docs/TODO.md under "User feedback on v0.9.0 (18 November)".

Save and provisioning

  • New project_save saves an open project in a worker-owned instance. It is refused for:
    • read-only projects;
    • projects with an unresolved change;
    • any project an unresolved admission holds (checked in the Host dispatcher).
  • simulation_download now reports projectModifiedAfter, saveRequiredBeforeProvisioning and nextStep.

Recovery after a failed provisioning

  • New simulation_provision_status lists each attempt with its stage, storage contents and the exact next calls.
  • New simulation_provision_recover runs detach → empty owned Portal → reconcile → reopen in one call. It refuses over unsaved edits and stops when the reconcile is held. Starting a fresh instance and making a new attempt stay separate calls, because the new instance needs the user's TLS authorization again.
  • ResourceBusy now lists blockingAdmissions, each with its operation, reconciliation tool and remediation.
  • UnsavedProject, SimulationProvisionStorageCollision and SimulationRegistrationsPresent now carry remediations.

Simulator symbols

  • Symbols are matched to the tag list's spelling, so "Db".A and Db.A both resolve.
  • A sim_write_signals batch that names one tag in both spellings is refused.

Smaller fixes

  • tia_detach reports PLCSIM instances that stay registered (plcsimRegistrations).
  • Change views carry projectSave (isModifiedAtPrepare, savedBeforeApply, savedAfterApply).
  • project_inventory explains why complete is false next to scopeComplete.
  • target_capabilities probes LoadableProvider per PLC.

Build identity

  • New-IsolatedBuild.ps1 and Package.ps1 record sourceCommit and sourceTreeDirty, and host_build_identity reports them.
  • The bundle folder suffix is random, not a commit; the docs now say so.

Unified alarms

  • New runtime_unified_* tools read active and logged alarms through the Unified PC Runtime GraphQL server: protected credential, pinned certificate, the UMC user's language rather than the server's en-US default, and fields taken from the server's schema.
  • Alarms are acknowledged by qualified path (System::Tag:Alarm), only on a runtime on this PC, and only with acknowledgeWrite.
  • Reference: docs/reference/unified-runtime-alarms.md.

Docs

  • TLS trust scope, sim_tags offsets for optimized DBs, the recovery steps, and the README/FAQ safety text.
  • X13 row 17.
  • Wiki Getting Started.
  • Feature catalog 0.4.187.

The TLS hash-binding question stays open for the maintainer. The provisioning claim is written before the TLS callback, so a pin known in advance could never match the certificate a fresh instance presents.

Validation

Offline

  • TiaMcp.Tests: 371/371.
  • TiaMcp.Engineering.Tests: passes, with 47 provisioning reconciliation, status and recovery checks and 32 Unified checks against a scripted GraphQL server.
  • test_contracts.py: 351 tools, 513 features.
  • test_api_coverage_bindings.py, test_api_coverage.py and test_block_test_runtime.py: 44 tests pass.
  • Viewer client tests: 13/13.
  • release_matrix, change_kinds and error_registry --check modes pass.
  • scripts/Test-Offline.ps1 -OutputDirectory artifacts/tv passes, except for:
    • the raw evidence-store audit, skipped (GITHUB_ACTIONS=true) because this workstation's local store is missing 642 files;
    • one OPC UA event-retransmission check (Duplicate event envelope remains visible with original retransmission). It failed in all three full-suite runs, which run suites in parallel, and passed 5 times alone (4 Debug, 1 Release). No OPC UA code changed.

Packaging

  • Package.ps1 -Offline built a bundle that passed Verify-TiaMcpBundle.ps1 -Strict.
  • Its manifest records sourceCommit 1671b2a with sourceTreeDirty: true.

Native (Debug builds, TIA V21, PLCSIM Advanced V8 Softbus, owned scratch projects)

  • Record: docs/verification/v090-feedback-20261118.md.
  • scripts/probe_feedback_20261118.py covered:
    • inventory meaning;
    • project_save no-op and save after download;
    • projectSave in change results;
    • the LoadableProvider probe, unavailable on a CPU 1511;
    • the download save fields;
    • provisioning without TLS trust leaving the attempt outcomeUnknown → status held → project_save refused with ResourceBusy → simulation_provision_recover released it and reopened the scratch.
  • scripts/validate_simulation.py --provision-runtime-credential --trust-owned-empty-cpu-certificate --golden-path-checks, with the user's explicit first-use TLS authorization (2 of 3 instances used):
    • download → project_save → provisioning → RUN → reads, writes and a sim_test scenario: completed: true;
    • quoted symbols read the same values as the tag list's spelling;
    • sim_tags offsets are 0 for optimized-DB members;
    • detach reported no leftover registrations.

Not tested natively

  • The Unified alarm tools: the runtime web server certificate on this PC expired on 27 March 2026, and no runtime project was running.
  • SimulationRegistrationsPresent details.
  • A mixed-spelling sim_write_signals batch.
  • A CPU 1518.
  • host_build_identity from an installed package.

Review checklist

  • Relevant tests and documentation reflect the change.
  • Support claims match the recorded target and evidence. The new catalog entries are unverified, and the TODO keeps the remaining native boxes open.
  • No credentials, customer project data, generated output or Siemens binaries are included.

🤖 Generated with Claude Code

A user ran the 12 November bundle against a protected scratch CPU on
PLCSIM Advanced V8 and reported the save/provision trap, a recovery
maze after a failed provisioning, and several misleading results.

- project_save saves an open project in a worker-owned instance; it is
  refused for read-only projects, unresolved changes and while an
  unresolved admission holds a project. simulation_download reports
  saveRequiredBeforeProvisioning and the next step.
- simulation_provision_status lists provisioning attempts with their
  stage and exact next calls; simulation_provision_recover runs detach,
  an empty owned Portal, the reconciliation and the reopen in one call.
  ResourceBusy names each blocking admission and its reconciliation
  tool; the provisioning refusals carry remediations.
- Simulator symbols are matched to the tag list's spelling, so
  "Db".Member and Db.Member both resolve.
- tia_detach reports PLCSIM instances that stay registered; change views
  carry projectSave; project_inventory explains complete versus
  scopeComplete; target_capabilities probes LoadableProvider per PLC.
- Isolated builds and bundle manifests record sourceCommit and
  sourceTreeDirty, and host_build_identity reports them.
- runtime_unified_* reads active and logged WinCC Unified PC Runtime
  alarms over GraphQL and acknowledges them by qualified path on a
  runtime on this PC (offline only so far).
- Docs: TLS trust scope, sim_tags offsets, recovery steps, Unified
  reference, README/FAQ safety text, X13 row 17, TODO section.

Offline suites pass apart from one OPC UA timing check that fails only
under full parallel load. Natively checked on owned scratch projects:
the refused-TLS recovery and the protected golden path
(docs/verification/v090-feedback-20261118.md). The Unified tools await
a live runtime.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Sparkz400
Sparkz400 merged commit 5c2efde into main Nov 18, 2026
17 checks passed
@Sparkz400
Sparkz400 deleted the claude/v090-p4-feedback branch November 18, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant