Repository navigation
Address the 18 November v0.9.0 feedback: project_save, provisioning recovery, Unified alarms - #311
Merged
Merged
Conversation
A user ran the 12 November bundle against a protected scratch CPU on PLCSIM Advanced V8 and reported the save/provision trap, a recovery maze after a failed provisioning, and several misleading results. - project_save saves an open project in a worker-owned instance; it is refused for read-only projects, unresolved changes and while an unresolved admission holds a project. simulation_download reports saveRequiredBeforeProvisioning and the next step. - simulation_provision_status lists provisioning attempts with their stage and exact next calls; simulation_provision_recover runs detach, an empty owned Portal, the reconciliation and the reopen in one call. ResourceBusy names each blocking admission and its reconciliation tool; the provisioning refusals carry remediations. - Simulator symbols are matched to the tag list's spelling, so "Db".Member and Db.Member both resolve. - tia_detach reports PLCSIM instances that stay registered; change views carry projectSave; project_inventory explains complete versus scopeComplete; target_capabilities probes LoadableProvider per PLC. - Isolated builds and bundle manifests record sourceCommit and sourceTreeDirty, and host_build_identity reports them. - runtime_unified_* reads active and logged WinCC Unified PC Runtime alarms over GraphQL and acknowledges them by qualified path on a runtime on this PC (offline only so far). - Docs: TLS trust scope, sim_tags offsets, recovery steps, Unified reference, README/FAQ safety text, X13 row 17, TODO section. Offline suites pass apart from one OPC UA timing check that fails only under full parallel load. Natively checked on owned scratch projects: the refused-TLS recovery and the protected golden path (docs/verification/v090-feedback-20261118.md). The Unified tools await a live runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
A user ran the 12 November engineering bundle against a protected scratch CPU on PLCSIM Advanced V8 and reported traps and misleading results. Each item is recorded in
docs/TODO.mdunder "User feedback on v0.9.0 (18 November)".Save and provisioning
project_savesaves an open project in a worker-owned instance. It is refused for:simulation_downloadnow reportsprojectModifiedAfter,saveRequiredBeforeProvisioningandnextStep.Recovery after a failed provisioning
simulation_provision_statuslists each attempt with its stage, storage contents and the exact next calls.simulation_provision_recoverruns detach → empty owned Portal → reconcile → reopen in one call. It refuses over unsaved edits and stops when the reconcile is held. Starting a fresh instance and making a new attempt stay separate calls, because the new instance needs the user's TLS authorization again.ResourceBusynow listsblockingAdmissions, each with its operation, reconciliation tool and remediation.UnsavedProject,SimulationProvisionStorageCollisionandSimulationRegistrationsPresentnow carry remediations.Simulator symbols
"Db".AandDb.Aboth resolve.sim_write_signalsbatch that names one tag in both spellings is refused.Smaller fixes
tia_detachreports PLCSIM instances that stay registered (plcsimRegistrations).projectSave(isModifiedAtPrepare,savedBeforeApply,savedAfterApply).project_inventoryexplains whycompleteis false next toscopeComplete.target_capabilitiesprobesLoadableProviderper PLC.Build identity
New-IsolatedBuild.ps1andPackage.ps1recordsourceCommitandsourceTreeDirty, andhost_build_identityreports them.Unified alarms
runtime_unified_*tools read active and logged alarms through the Unified PC Runtime GraphQL server: protected credential, pinned certificate, the UMC user's language rather than the server's en-US default, and fields taken from the server's schema.System::Tag:Alarm), only on a runtime on this PC, and only withacknowledgeWrite.docs/reference/unified-runtime-alarms.md.Docs
sim_tagsoffsets for optimized DBs, the recovery steps, and the README/FAQ safety text.The TLS hash-binding question stays open for the maintainer. The provisioning claim is written before the TLS callback, so a pin known in advance could never match the certificate a fresh instance presents.
Validation
Offline
TiaMcp.Tests: 371/371.TiaMcp.Engineering.Tests: passes, with 47 provisioning reconciliation, status and recovery checks and 32 Unified checks against a scripted GraphQL server.test_contracts.py: 351 tools, 513 features.test_api_coverage_bindings.py,test_api_coverage.pyandtest_block_test_runtime.py: 44 tests pass.release_matrix,change_kindsanderror_registry--checkmodes pass.scripts/Test-Offline.ps1 -OutputDirectory artifacts/tvpasses, except for:GITHUB_ACTIONS=true) because this workstation's local store is missing 642 files;Duplicate event envelope remains visible with original retransmission). It failed in all three full-suite runs, which run suites in parallel, and passed 5 times alone (4 Debug, 1 Release). No OPC UA code changed.Packaging
Package.ps1 -Offlinebuilt a bundle that passedVerify-TiaMcpBundle.ps1 -Strict.sourceCommit1671b2a withsourceTreeDirty: true.Native (Debug builds, TIA V21, PLCSIM Advanced V8 Softbus, owned scratch projects)
docs/verification/v090-feedback-20261118.md.scripts/probe_feedback_20261118.pycovered:meaning;project_saveno-op and save after download;projectSavein change results;outcomeUnknown→ statusheld→project_saverefused withResourceBusy→simulation_provision_recoverreleased it and reopened the scratch.scripts/validate_simulation.py --provision-runtime-credential --trust-owned-empty-cpu-certificate --golden-path-checks, with the user's explicit first-use TLS authorization (2 of 3 instances used):project_save→ provisioning → RUN → reads, writes and asim_testscenario:completed: true;sim_tagsoffsets are 0 for optimized-DB members;Not tested natively
SimulationRegistrationsPresentdetails.sim_write_signalsbatch.host_build_identityfrom an installed package.Review checklist
unverified, and the TODO keeps the remaining native boxes open.🤖 Generated with Claude Code