(major/non-breaking?) Modules Refactor #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plugin in root repo
jcxldn
added
feature
kaylendog
reviewed
Mar 3, 2021
Collaborator
kaylendog
left a comment
kaylendog
left a comment
There was a problem hiding this comment.
Some minor formatting complaints that I will fix in a second - pls see comments on the build files.
bukkit/src/main/java/com/dumbdogdiner/stickyapi/bukkit/nms/PacketInjector.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=============================================
+ Coverage 23.19% 34.39% +11.20%
=============================================
Files 73 63 -10
Lines 3126 2532 -594
Branches 426 286 -140
=============================================
+ Hits 725 871 +146
+ Misses 2355 1597 -758
- Partials 46 64 +18
Continue to review full report at Codecov.
|
kaylendog
reviewed
Mar 3, 2021
Collaborator
kaylendog
left a comment
kaylendog
left a comment
There was a problem hiding this comment.
Fixed formatting comments.
kaylendog
reviewed
Mar 21, 2021
Collaborator
kaylendog
left a comment
kaylendog
left a comment
There was a problem hiding this comment.
LGTM - some formatting thingies.
| * Copyright (c) 2020-2021 DumbDogDiner <dumbdogdiner.com>. All rights reserved. | ||
| * Licensed under the MIT license, see LICENSE for more information... | ||
| */ | ||
| package com.dumbdogdiner.stickyapi.bungeecord.util; |
Collaborator
There was a problem hiding this comment.
This looks very similar to the Bukkit startup util - perhaps some de-dupe here?
config/src/main/java/com/dumbdogdiner/stickyapi/common/config/Configuration.java
Outdated
Show resolved
Hide resolved
| // Generate dumper options | ||
| DumperOptions options = new DumperOptions(); | ||
| options.setDefaultFlowStyle(DumperOptions.FlowStyle.BLOCK); | ||
| options.setIndent(2); |
Collaborator
There was a problem hiding this comment.
4 tab indentation hhhhh - vlad will complain but idc >:3
Closed
3 tasks
* Add browseJavadoc, allow frames support * update gradle * Fix javadoc issue * Generate javadoc for private * Switch back to gradle 6.7 * Don't duplicate allprojects directive; remove extra encoding option * Add trailing newline Co-authored-by: James <[email protected]> Co-authored-by: Andrew Katz <[email protected]>
kaylendog
approved these changes
Mar 24, 2021
| /* | ||
| * Copyright (c) 2020-$YEAR DumbDogDiner <dumbdogdiner.com>. All rights reserved. | ||
| * Licensed under the MIT license, see LICENSE for more information... | ||
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Partial(?) changelog from previous tagged release
StickyAPI v3 Changelog
Upgrade Notes
Module support (dependency resolution change)
com.dumbdogdiner:stickyapiis still available, but is not recommendedPlease use
com.dumbdogdiner:stickyapi-(module)instead.breaking: Config rewrite (Rewrite the configuration package (very basic for now) #98)
Internal (ci)
Internal
Dependencies
net.nemerosa.versioning:2.8.2->2.14.0classgraph:4.8.98->4.8.100New Features
com.dumbdogdiner.stickyapi.StickyAPI(Feat/jcx/buildinfo #77)VoidGeneratorDeprecations
getRandomNumbercom.dumbdogdiner.stickyapi.bukkit.nms