Skip to content

Conversation

@jcxldn
Copy link
Member

@jcxldn jcxldn commented Mar 29, 2021

Most of the groundwork was laid out in #97.

Setting as a draft due to the pre-release nature of this PR.

Changes in this PR:

  • Switched to gradle wrapper 7.0
  • Added java 16 to CI matrix
  • Remove duplicate lombok dependency (already provided by plugin)

Gradle 7 specific changes

  • Remove jcenter() repository
  • Add dependsOn to rootSources, copySubProjectJars and rootJacocoMergedReport to resolve gradle 7 implicit dependency warnings

Java 16 specific changes

@jcxldn jcxldn added ci/cd dependencies Pull requests that update a dependency file feature New feature or request ops labels Mar 29, 2021
@jcxldn jcxldn added this to the v3.0 (next) milestone Mar 29, 2021
@jcxldn jcxldn self-assigned this Mar 29, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #109 (0b6e6ad) into master (2afbdf2) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   34.51%   34.39%   -0.12%     
==========================================
  Files          63       63              
  Lines        2532     2532              
  Branches      286      286              
==========================================
- Hits          874      871       -3     
- Misses       1595     1597       +2     
- Partials       63       64       +1     
Impacted Files Coverage Δ
...dumbdogdiner/stickyapi/common/util/StringUtil.java 91.13% <0.00%> (-3.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afbdf2...0b6e6ad. Read the comment docs.

@jcxldn jcxldn marked this pull request as ready for review April 10, 2021 08:16
@jcxldn jcxldn requested a review from a team as a code owner April 10, 2021 08:16
@jcxldn jcxldn merged commit 5d9083d into master Apr 10, 2021
@jcxldn jcxldn deleted the feat/jcx/2021/java16 branch April 10, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd dependencies Pull requests that update a dependency file feature New feature or request ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants