Skip to content

fix: 空任务栏渲染出字面 "[]"——each_window 块返回值不外泄 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShiningRay merged 1 commit into from
Sep 15, 2026
Merged

fix: 空任务栏渲染出字面 "[]"——each_window 块返回值不外泄 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/beryl/window.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ def record(id)

def each_window
@order.get.each { |id| yield @records[id] }
nil # 块的返回值不外泄——否则空窗时块返回 []，会被渲染层 tos 成可见 "[]" 文本
end

# ── 状态查询（view 内读取即响应式）────────────────────
Expand Down
7 changes: 7 additions & 0 deletions test/window_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,13 @@ def test_taskbar_renders_and_toggles
assert wm.active?(:b)
end

def test_taskbar_empty_renders_no_brackets
wm = Beryl::WindowManager.new(viewport: VP)
html = render(TaskbarHost.new(wm))
refute_includes html, '[]' # each_window 空表不外泄：块返回值曾被 tos 成可见 "[]"
assert_includes html, 'b-taskbar'
end

# ── WindowFrame chrome / minimized ────────────────────

def test_window_frame_chrome_is_opt_in
Expand Down