Repository navigation
fix: 空任务栏渲染出字面 "[]"——each_window 块返回值不外泄 - #1
Merged
Merged
Conversation
wm.each_window 返回 @order.get.each 的结果,窗口全关时 Taskbar 的块 返回 [],被渲染层 tos 成可见 "[]" 文本。显式返回 nil,附回归测试 test_taskbar_empty_renders_no_brackets。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
窗口全部关闭时,Taskbar 左侧出现可见的字面
[]文本:wm.each_window返回@order.get.each的结果,空表时块返回[],被渲染层 tos 成文本节点。修复
each_window显式返回nil,块返回值不再外泄。测试
test_taskbar_empty_renders_no_brackets(渲染空 WM 任务栏 refute[])bundle exec rake81 项全绿(含 Opal 编译验收)