Skip to content

fix pin concat crash #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7w1 merged 1 commit into from
May 15, 2026
+24 −22
Merged

fix pin concat crash #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-pinned-events-timeline-crash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

Fixed crash when rendering some `m.room.pinned_events` timeline rows (old/malformed pin state edge case).
41 changes: 19 additions & 22 deletions src/app/hooks/timeline/useTimelineEventRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,6 +1060,9 @@ export function useTimelineEventRenderer({
const pinsRemoved =
(prevPinned && pinned && prevPinned.filter((x: string) => !pinned.includes(x))) || [];

const pinPreviewIds = (pinsAdded ?? []).concat(...(pinsRemoved ?? []));
const pinnedSet = new Set(pinned ?? []);

const timeJSX = (
<Time
ts={mEvent.getTs()}
Expand Down Expand Up @@ -1104,28 +1107,22 @@ export function useTimelineEventRenderer({
`has not changed the pins`) ||
`:`}
</Text>
{(pinsAdded || pinsRemoved) &&
pinsAdded
.concat(...pinsRemoved)
.slice(0, 4)
.map((x: string) => (
<Reply
key={x}
style={{ opacity: '80%' }}
room={room}
replyEventId={x}
onClick={handleOpenReply}
replyIcon={
<>
<Icon size="100" src={Icons.Pin} />
<Icon
size="100"
src={pinned.includes(x) ? Icons.Plus : Icons.Minus}
/>
</>
}
/>
))}
{pinPreviewIds.length > 0 &&
pinPreviewIds.slice(0, 4).map((x: string) => (
<Reply
key={x}
style={{ opacity: '80%' }}
room={room}
replyEventId={x}
onClick={handleOpenReply}
replyIcon={
<>
<Icon size="100" src={Icons.Pin} />
<Icon size="100" src={pinnedSet.has(x) ? Icons.Plus : Icons.Minus} />
</>
}
/>
))}
</Box>
}
/>
Expand Down
Loading