fix pin concat crash#848
Merged
Merged
Conversation
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-848-sable.raspy-dream-bb1d.workers.dev | d04f84e | pr-848 |
Fri, 15 May 2026 04:52:48 GMT |
Hr-ArshA
pushed a commit
to Hr-ArshA/Sable
that referenced
this pull request
May 15, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Fixes * Fix issues related to editing messages with links losing previews or gaining \<> ([SableClient#847](<SableClient#847>) by @7w1) * Made markdown headers also function properly with single new lines instead of only two new lines. ([SableClient#837](<SableClient#837>) by @7w1) * Fix mentions not being linkfied. ([SableClient#837](<SableClient#837>) by @7w1) * Fixed crash when rendering some `m.room.pinned_events` timeline rows (old/malformed pin state edge case). ([SableClient#848](<SableClient#848>) by @7w1) * Fixed reply chips for deleted messages and media without captions showing `m.room.message` type instead of the event. ([SableClient#846](<SableClient#846>) by @7w1) * Fixed room pings looking like normal message links instead of pings. ([SableClient#837](<SableClient#837>) by @7w1) * Properly centered message loading indicators to avoid brief scrollbar shift while loading messages. ([SableClient#849](<SableClient#849>) by @7w1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Untested fix for #834 , just adds an additional check to make sure that we aren't trying to concat on an empty array which I think is likely what caused the crash.
Type of change
Checklist:
AI disclosure: