Skip to content

fix: 1.1.1 Changed tag from label to div in ToggleSwitch #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: 1.1.1 Changed tag from label to div in ToggleSwitch #1642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1de58b
Changed tag from label to div
ergotse May 15, 2025
23263cb
Made outer Box's type to be changeable
ergotse May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/fuselage/src/components/ToggleSwitch/ToggleSwitch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,16 @@ export const ToggleSwitch = forwardRef(function ToggleSwitch(
}: ComponentProps<typeof Box> & AllHTMLAttributes<HTMLInputElement>,
ref: Ref<HTMLInputElement>,
) {
const { is: outerIs = 'label', ...rest } = props;

return (
<Box is='label' className={className} rcx-toggle-switch>
<Box is={outerIs} className={className} rcx-toggle-switch>
<Box
is='input'
ref={ref}
rcx-toggle-switch__input
type='checkbox'
{...props}
{...rest}
/>
<Box is='i' rcx-toggle-switch__fake aria-hidden='true' />
</Box>
Expand Down