Skip to content

Conversation

ergot-rp
Copy link

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

Copy link

changeset-bot bot commented May 15, 2025

⚠️ No Changeset found

Latest commit: 23263cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ergot-rp ergot-rp changed the title 1.1.1 fix: Changed tag from label to div in ToggleSwitch fix: 1.1.1 Changed tag from label to div in ToggleSwitch May 15, 2025
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change will break the component, we need to think about a way to fix it properly

@ivans-netto
Copy link

ivans-netto commented May 20, 2025

I've spoke with Henriques and removing the <label> wrapper from inputs will have other implications through out Rocket.Chat software. The front-end team will need to decide what can be done in this case. Expect a reply until next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants