feat: Integrate epoch_processing EF test with our implementation #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
requested changes
Mar 11, 2025
Comment on lines
1654
to
1659
| for (index, reward) in rewards.iter().enumerate() { | ||
| // Increase balance for the validator based on rewards | ||
| self.increase_balance(index as u64, *reward)?; | ||
|
|
||
| // Decrease balance for the validator based on penalties | ||
| self.decrease_balance(index as u64, penalties[index])?; |
There was a problem hiding this comment.
can we revert this to what it was before?
KolbyML
reviewed
Mar 11, 2025
| for index in initiate_validator { | ||
| self.initiate_validator_exit(index); | ||
| } | ||
|
|
||
| // Queue validators eligible for activation and not yet dequeued for activation | ||
| let mut activation_queue: Vec<usize> = (0..self.validators.len()) | ||
| // Order by the sequence of activation_eligibility_epoch setting and then index | ||
| // Order by the sequence of activation_eligibility_epoch setting and then in |
There was a problem hiding this comment.
Suggested change
| // Order by the sequence of activation_eligibility_epoch setting and then in | |
| // Order by the sequence of activation_eligibility_epoch setting and then index |
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#132
Implementing tests for epoch_processing
Created issues for the tests that failed for fixing the beacon state functions Issues: #160, #161