Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate epoch_processing EF test with our implementation #132

Closed
syjn99 opened this issue Feb 24, 2025 · 7 comments
Closed

Integrate epoch_processing EF test with our implementation #132

syjn99 opened this issue Feb 24, 2025 · 7 comments
Assignees
Labels

Comments

@syjn99
Copy link
Member

syjn99 commented Feb 24, 2025

After #130 is completed, we can start working on epoch_processing tests.

https://github.com/ethereum/consensus-specs/tree/dev/tests/formats/epoch_processing

@syjn99 syjn99 added the testing label Feb 24, 2025
@bomanaps
Copy link

Can I take this?

@syjn99
Copy link
Member Author

syjn99 commented Feb 26, 2025

@bomanaps
Assigned. If you have any problem, please let me know

@bomanaps
Copy link

bomanaps commented Mar 1, 2025

Hello @syjn99 @unnawut @jihoonsong @KolbyML I have been going through this to understand how to create a test case for each of the sub_transitions listed in the epoch_processing function. Each test case will have a pre_state and a post_state, meaning it must include meta.yml (which will contain data like a description and a BLS setting), pre.ssz_snappy, and post.ssz_snappy. But I am confused about how to adapt the testing approach since this is not applied to Beam. Please correct me if I am wrong.

@KolbyML
Copy link
Member

KolbyML commented Mar 1, 2025

Hello @syjn99 @unnawut @jihoonsong @KolbyML I have been going through this to understand how to create a test case for each of the sub_transitions listed in the epoch_processing function. Each test case will have a pre_state and a post_state, meaning it must include meta.yml (which will contain data like a description and a BLS setting), pre.ssz_snappy, and post.ssz_snappy. But I am confused about how to adapt the testing approach since this is not applied to Beam. Please correct me if I am wrong.

Hi @bomanaps these tests are for the Beacon chain, read this issue for the rational on why we are building our a minimal implementation of the Beacon spec #134

Please feel free to ask any followup if you are still confused or have more!

@Kayden-ML
Copy link
Contributor

Hey @bomanaps are you still interested on these tests as these tests are blocking me from implementing other tests, if your no longer interested let me know i could start working on them

@bomanaps
Copy link

bomanaps commented Mar 7, 2025

Okay you can have it.

@Kayden-ML
Copy link
Contributor

Implemented in this PR #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants