Skip to content

Additional stock MK3S hardware support #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Additional stock MK3S hardware support #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa0cad2
Templates: add missing LCD Backlight control for mk3 template
kronflux Dec 28, 2024
b46b697
Boards: add missing board temperature
kronflux Dec 28, 2024
fe6ca56
Steppers: add missing Bondtech LGX presets
kronflux Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions configuration/boards/prusa-einsy/config.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ aliases:
e_step_pin=PC3, e_dir_pin=PL6, e_enable_pin=PA4, e_diag_pin=PK3, e_uart_pin=PK4, e_heater_pin=PE5, e_sensor_pin=PF0,
# auto leveling
probe_pin=PB4,
# Board temperature
temperature_einsy=PF6,
# fans
4p_fan_part_cooling_pin=PH3,
4p_fan_part_cooling_tach_pin=PE7,
Expand All @@ -35,9 +37,16 @@ aliases:
display_encoder_pin1=PJ1,
display_encoder_pin2=PJ2,
display_click_pin=PH6,
display_backlight_pin=PE3,
Copy link
Member

@miklschmidt miklschmidt Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a standard pin alias (neither are the other display_* aliases, they aren't used, they're only there for backwards compatibility with 2.0 configs) and will be ignored by the configurator. Remove it.

display_beeper_pin=PH2,


[temperature_sensor einsy]
Copy link
Member

@miklschmidt miklschmidt Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work in 2.1, the configurator only uses this file to read the board alias map. You can put it in the template, commented out, like you did with the display backlight pin. It's ugly, but there's no other way to do non-standard things currently.

sensor_pin: temperature_einsy
sensor_type: TDK NTCG104LH104JT1
min_temp: 0
max_temp: 100

[mcu]
serial: /dev/prusa-einsy
restart_method: command
8 changes: 8 additions & 0 deletions configuration/printers/prusa-mk3s/display.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ d7_pin: display_d7_pin
encoder_pins: ^display_encoder_pin1,^display_encoder_pin2
click_pin: ^!display_click_pin

[output_pin LCD_backlight_pin]
Copy link
Member

@miklschmidt miklschmidt Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be removed. RatOS currently has no concept of lcd displays. There's a feature in development to allow for "accessories" to support arbitrary things like this, until then it will have to be a commented out section in the printer.cfg template.

pin: display_backlight_pin
pwm: True
hardware_pwm: True
value: 0.01
shutdown_value: 1
cycle_time: 0.001

[output_pin BEEPER_pin]
Copy link
Member

@miklschmidt miklschmidt Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar for this actually, this should also be removed (or moved to the printer template)

pin: display_beeper_pin
pwm: True
Expand Down
17 changes: 17 additions & 0 deletions src/data/steppers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,23 @@ export const Steppers = z.array(Stepper).parse([
id: 'BONDTECH-42H025H-0704-002',
title: 'Bondtech LGX Stepper',
maxPeakCurrent: 0.7,
presets: [
Copy link
Member

@miklschmidt miklschmidt Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do these values come from?

Copy link
Author

@kronflux kronflux Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the datasheet for the motor itself, and referencing other klipper configurations for the MK3S they appear to be referencing the datasheet as well

{
run_current: 0.54,
voltage: 24,
driver: 'TMC2130',
sense_resistor: 0.22,
driver_IHOLDDELAY: 8,
driver_TPOWERDOWN: 0,
driver_TBL: 2,
driver_TOFF: 3,
driver_HEND: 1,
driver_HSTRT: 5,
driver_PWM_FREQ: 2,
driver_PWM_GRAD: 4,
driver_PWM_AMPL: 240,
driver_PWM_AUTOSCALE: true,
},
},
{
id: 'LDO-42STH48-2504AC',
Expand Down
8 changes: 8 additions & 0 deletions src/templates/prusa-mk3s.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,14 @@ variable_filament_load_speed: 5
#encoder_pins: ^PJ1,^PJ2
#click_pin: ^!PH6

#[output_pin LCD_backlight_pin]
#pin: PE3
#pwm: True
#hardware_pwm: True
#value: 0.01
#shutdown_value: 1
#cycle_time: 0.001

#[output_pin BEEPER_pin]
#pin: PH2
#pwm: True
Expand Down