Skip to content

Conversation

@kronflux
Copy link

Added LCD backlight control and Einsy board temperature sensor

display_beeper_pin=PH2,


[temperature_sensor einsy]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work in 2.1, the configurator only uses this file to read the board alias map. You can put it in the template, commented out, like you did with the display backlight pin. It's ugly, but there's no other way to do non-standard things currently.

display_encoder_pin1=PJ1,
display_encoder_pin2=PJ2,
display_click_pin=PH6,
display_backlight_pin=PE3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a standard pin alias (neither are the other display_* aliases, they aren't used, they're only there for backwards compatibility with 2.0 configs) and will be ignored by the configurator. Remove it.

encoder_pins: ^display_encoder_pin1,^display_encoder_pin2
click_pin: ^!display_click_pin

[output_pin LCD_backlight_pin]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be removed. RatOS currently has no concept of lcd displays. There's a feature in development to allow for "accessories" to support arbitrary things like this, until then it will have to be a commented out section in the printer.cfg template.

shutdown_value: 1
cycle_time: 0.001

[output_pin BEEPER_pin]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar for this actually, this should also be removed (or moved to the printer template)

id: 'BONDTECH-42H025H-0704-002',
title: 'Bondtech LGX Stepper',
maxPeakCurrent: 0.7,
presets: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do these values come from?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the datasheet for the motor itself, and referencing other klipper configurations for the MK3S they appear to be referencing the datasheet as well

@kronflux
Copy link
Author

my machine actually kicked the bucket, something up with my hotend so I won't be able to make adjustments or test this further, but hopefully some of it is helpful
Feel free to merge or discard whatever you wish :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants