Validate kubevirt-velero-plugin is enabled to ensure VM resource protection #2311
+531
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
from
6c8ac7a to
cffbd42
Compare
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
4 times, most recently
from
bf0c9e0 to
1a53e5e
Compare
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
from
1a53e5e to
f7846dc
Compare
raaizik
reviewed
Nov 9, 2025
Member
raaizik
left a comment
raaizik
left a comment
There was a problem hiding this comment.
Here's my review.
Some more comments:
- It would be good to include some unit tests for the new validation logic — for example, verifying that
isKubeVirtEnabled()correctly detects the plugin when present or missing, and thatrecipeVMBackupValidate()behaves accordingly. This would help catch regressions early. - Is there already documentation in the codebase that covers the requirement for Velero and the kubevirt-velero-plugin when protecting VM resources? If not, it might be worth adding or referencing it in a follow-up PR to make this dependency clearer to users.
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
2 times, most recently
from
accaaf6 to
9b178ce
Compare
Member
|
Small nit. Other than that LGTM. |
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
from
9b178ce to
6ad6d73
Compare
raaizik
reviewed
Nov 10, 2025
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
3 times, most recently
from
8d93e3a to
7b0121e
Compare
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
from
7b0121e to
814c77a
Compare
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
7 times, most recently
from
286c806 to
4e99673
Compare
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
4 times, most recently
from
2bfa44f to
58b5294
Compare
raghavendra-talur
requested changes
Nov 25, 2025
internal/controller/vrg_recipe.go
Outdated
| if err := recipeVMBackupValidate(ctx, reader, recipeElements, vrg, ramenConfig, log); err != nil { | ||
| return recipeElements, fmt.Errorf("recipe %v VM backup validation error: %w", recipeNamespacedName.String(), err) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I don't think this call should happen within RecipeElementsGet. Please move the call outside to the place where you already have the recipe elements.
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
from
58b5294 to
f99e9bb
Compare
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
7 times, most recently
from
2d436cf to
aa2f8e1
Compare
This update introduces validation logic to ensure that the kubevirt-velero-plugin is properly enabled and configured within the Velero deployment for DR protection of VirtualMachines using the internal recipe `vm-recipe`. The plugin is essential for enabling backup and restore operations for KubeVirt-managed VirtualMachines (VMs), DataVolumes (DVs), PersistentVolumeClaims (PVCs), and associated resources. Includes unit tests to verify the correctness of the validation logic. Signed-off-by: pruthvitd <[email protected]>
pruthvitd
force-pushed
the
validate-kubevirt-plugin
branch
from
aa2f8e1 to
9dc09fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces validation logic to ensure that the kubevirt-velero-plugin is properly enabled and configured in the Velero deployment for Disaster Recovery (DR) protection of VirtualMachines using the internal recipe vm-recipe. The plugin is essential for enabling backup and restore operations for KubeVirt-managed VirtualMachines (VMs), DataVolumes (DVs), PersistentVolumeClaims (PVCs), and associated resources.
Key changes:
Fixes: 2313