Add validation for kubevirt-velero-plugin and UT

This update introduces validation logic to ensure that the kubevirt-velero-plugin
is properly enabled and configured within the Velero deployment for DR protection
of VirtualMachines using the internal recipe `vm-recipe`. The plugin is essential
for enabling backup and restore operations for KubeVirt-managed VirtualMachines (VMs),
DataVolumes (DVs), PersistentVolumeClaims (PVCs), and associated resources.

Includes unit tests to verify the correctness of the validation logic.

Signed-off-by: pruthvitd <[email protected]>

Author: pruthvitd

Makefile

@@ -181,6 +181,9 @@ test-vrg-vs: generate manifests envtest ## Run VolumeReplicationGroupVolSync tes
 test-vrg-recipe: generate manifests envtest ## Run VolumeReplicationGroupRecipe tests.
 	 go test ./internal/controller -coverprofile cover.out  -ginkgo.focus VolumeReplicationGroupRecipe
 
+test-vrg-vmrecipe: generate manifests envtest
+	 go test ./internal/controller -coverprofile cover.out  -ginkgo.focus VolumeReplicationGroupVMRecipe
+
 test-vrg-kubeobjects: generate manifests envtest ## Run VolumeReplicationGroupKubeObjects tests.
 	 go test ./internal/controller -coverprofile cover.out  -ginkgo.focus VRG_KubeObjectProtection
 

internal/controller/drplacementcontrol_controller.go

@@ -1404,9 +1404,6 @@ func (r *DRPlacementControlReconciler) updateResourceCondition(
 		ProtectedPVCs:   extractProtectedPVCNames(vrg),
 	}
 
-	drpc.Status.ResourceConditions.Conditions = assignConditionsWithConflictCheck(
-		vrgs, vrg, VRGConditionTypeNoClusterDataConflict)
-
 	if vrg.Status.PVCGroups != nil {
 		drpc.Status.ResourceConditions.ResourceMeta.PVCGroups = vrg.Status.PVCGroups
 	}
@@ -1421,7 +1418,7 @@ func (r *DRPlacementControlReconciler) updateResourceCondition(
 		drpc.Status.LastKubeObjectProtectionTime = &vrg.Status.KubeObjectProtection.CaptureToRecoverFrom.EndTime
 	}
 
-	updateDRPCProtectedCondition(drpc, vrg, clusterName)
+	updateDRPCProtectedCondition(drpc, vrg, clusterName, vrgs)
 }
 
 // getVRG retrieves a VRG either from the provided map or fetches it from the managed cluster/S3 store.
@@ -1482,85 +1479,6 @@ func extractProtectedPVCNames(vrg *rmn.VolumeReplicationGroup) []string {
 	return protectedPVCs
 }
 
-// findConflictCondition selects the appropriate condition from VRGs based on the conflict type.
-func findConflictCondition(vrgs map[string]*rmn.VolumeReplicationGroup, conflictType string) *metav1.Condition {
-	var selectedCondition *metav1.Condition
-
-	for _, vrg := range vrgs {
-		condition := meta.FindStatusCondition(vrg.Status.Conditions, conflictType)
-		if condition != nil && condition.Status == metav1.ConditionFalse {
-			// Prioritize primary VRG's condition if available
-			if isVRGPrimary(vrg) {
-				return condition // Exit early if primary VRG condition is found
-			}
-
-			// Assign the first non-primary VRG's condition if no primary found yet
-			if selectedCondition == nil {
-				selectedCondition = condition
-			}
-		}
-	}
-
-	return selectedCondition
-}
-
-// assignConditionsWithConflictCheck assigns conditions from a given VRG while prioritizing conflict conditions.
-func assignConditionsWithConflictCheck(vrgs map[string]*rmn.VolumeReplicationGroup,
-	vrg *rmn.VolumeReplicationGroup, conflictType string,
-) []metav1.Condition {
-	conditions := &vrg.Status.Conditions
-	conflictCondition := findConflictCondition(vrgs, conflictType)
-
-	// Ensure the conflict condition is present in the conditions list
-	if conflictCondition != nil {
-		setConflictStatusCondition(conditions, *conflictCondition)
-	}
-
-	return *conditions
-}
-
-func setConflictStatusCondition(existingConditions *[]metav1.Condition,
-	newCondition metav1.Condition,
-) metav1.Condition {
-	if existingConditions == nil {
-		existingConditions = &[]metav1.Condition{}
-	}
-
-	existingCondition := rmnutil.FindCondition(*existingConditions, newCondition.Type)
-	if existingCondition == nil {
-		newCondition.LastTransitionTime = metav1.NewTime(time.Now())
-		*existingConditions = append(*existingConditions, newCondition)
-
-		return newCondition
-	}
-
-	if existingCondition.Status != newCondition.Status ||
-		existingCondition.Reason != newCondition.Reason {
-		existingCondition.Status = newCondition.Status
-		existingCondition.Reason = newCondition.Reason
-		existingCondition.LastTransitionTime = metav1.NewTime(time.Now())
-	}
-
-	defaultValue := "none"
-	if newCondition.Reason == "" {
-		newCondition.Reason = defaultValue
-	}
-
-	if newCondition.Message == "" {
-		newCondition.Message = defaultValue
-	}
-
-	existingCondition.Reason = newCondition.Reason
-	existingCondition.Message = newCondition.Message
-	// TODO: Why not update lastTranTime if the above change?
-
-	if existingCondition.ObservedGeneration != newCondition.ObservedGeneration {
-		existingCondition.LastTransitionTime = metav1.NewTime(time.Now())
-	}
-
-	return *existingCondition
-}
-
 // clusterForVRGStatus determines which cluster's VRG should be inspected for status updates to DRPC
 func (r *DRPlacementControlReconciler) clusterForVRGStatus(
 	drpc *rmn.DRPlacementControl, userPlacement client.Object, log logr.Logger,

internal/controller/protected_condition.go

@@ -5,11 +5,13 @@ package controllers
 
 import (
 	"fmt"
+	"time"
 
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 
 	rmn "github.com/ramendr/ramen/api/v1alpha1"
+	rmnutil "github.com/ramendr/ramen/internal/controller/util"
 )
 
 func updateProtectedConditionUnknown(drpc *rmn.DRPlacementControl, clusterName string) {
@@ -29,16 +31,17 @@ func updateDRPCProtectedCondition(
 	drpc *rmn.DRPlacementControl,
 	vrg *rmn.VolumeReplicationGroup,
 	clusterName string,
+	vrgs map[string]*rmn.VolumeReplicationGroup,
 ) {
 	if updateVRGClusterDataReady(drpc, vrg, clusterName) {
 		return
 	}
 
-	if updateDRPCProtectedForReplicationState(drpc, vrg, clusterName) {
+	if updateDRPCProtectedForReplicationState(drpc, vrg, clusterName, vrgs) {
 		return
 	}
 
-	if updateVRGNoClusterDataConflict(drpc, vrg, clusterName) {
+	if updateVRGNoClusterDataConflict(drpc, vrg, vrgs) {
 		return
 	}
 
@@ -65,13 +68,19 @@ func updateDRPCProtectedForReplicationState(
 	drpc *rmn.DRPlacementControl,
 	vrg *rmn.VolumeReplicationGroup,
 	clusterName string,
+	vrgs map[string]*rmn.VolumeReplicationGroup,
 ) bool {
+	var fromCluster string
+
+	drpc.Status.ResourceConditions.Conditions, fromCluster = mergeVRGsConditions(
+		vrgs, vrg, VRGConditionTypeDataReady)
+
 	switch vrg.Spec.ReplicationState {
 	case rmn.Primary:
-		return updateVRGDataReadyAsPrimary(drpc, vrg, clusterName) ||
+		return updateVRGDataReadyAsPrimary(drpc, vrg, fromCluster) ||
 			updateVRGDataProtectedAsPrimary(drpc, vrg, clusterName)
 	case rmn.Secondary:
-		return updateVRGDataReadyAsSecondary(drpc, vrg, clusterName) ||
+		return updateVRGDataReadyAsSecondary(drpc, vrg, fromCluster) ||
 			updateVRGDataProtectedAsSecondary(drpc, vrg, clusterName)
 	}
 
@@ -186,8 +195,13 @@ func updateVRGDataProtectedAsPrimary(drpc *rmn.DRPlacementControl,
 //   - Returns a bool that is true if status was updated, and false otherwise
 func updateVRGNoClusterDataConflict(drpc *rmn.DRPlacementControl,
 	vrg *rmn.VolumeReplicationGroup,
-	clusterName string,
+	vrgs map[string]*rmn.VolumeReplicationGroup,
 ) bool {
+	var clusterName string
+
+	drpc.Status.ResourceConditions.Conditions, clusterName = mergeVRGsConditions(
+		vrgs, vrg, VRGConditionTypeNoClusterDataConflict)
+
 	return genericUpdateProtectedForCondition(drpc, vrg, clusterName, VRGConditionTypeNoClusterDataConflict,
 		"workload data protection", "checking for workload data conflict", "conflicting workload data")
 }
@@ -306,3 +320,87 @@ func updateMiscVRGStatus(drpc *rmn.DRPlacementControl,
 
 	return !updated
 }
+
+// findConflictCondition selects the appropriate condition from VRGs based on the conflict type.
+func findConflictCondition(vrgs map[string]*rmn.VolumeReplicationGroup,
+	conflictType string,
+) (*metav1.Condition, string) {
+	var selectedCondition *metav1.Condition
+
+	var clusterName string
+
+	for _, vrg := range vrgs {
+		condition := meta.FindStatusCondition(vrg.Status.Conditions, conflictType)
+		if condition != nil && condition.Status == metav1.ConditionFalse {
+			// Prioritize primary VRG's condition if available
+			clusterName = vrg.GetAnnotations()[DestinationClusterAnnotationKey]
+			if isVRGPrimary(vrg) {
+				return condition, clusterName // Exit early if primary VRG condition is found
+			}
+
+			// Assign the first non-primary VRG's condition if no primary found yet
+			if selectedCondition == nil {
+				selectedCondition = condition
+			}
+		}
+	}
+
+	return selectedCondition, clusterName
+}
+
+// mergeVRGsConditions assigns conditions from a given VRG while prioritizing conflict conditions.
+func mergeVRGsConditions(vrgs map[string]*rmn.VolumeReplicationGroup,
+	vrg *rmn.VolumeReplicationGroup, conflictType string,
+) ([]metav1.Condition, string) {
+	conditions := &vrg.Status.Conditions
+	conflictCondition, clusterName := findConflictCondition(vrgs, conflictType)
+
+	// Ensure the conflict condition is present in the conditions list
+	if conflictCondition != nil {
+		setConflictStatusCondition(conditions, *conflictCondition)
+	}
+
+	return *conditions, clusterName
+}
+
+func setConflictStatusCondition(existingConditions *[]metav1.Condition,
+	newCondition metav1.Condition,
+) metav1.Condition {
+	if existingConditions == nil {
+		existingConditions = &[]metav1.Condition{}
+	}
+
+	existingCondition := rmnutil.FindCondition(*existingConditions, newCondition.Type)
+	if existingCondition == nil {
+		newCondition.LastTransitionTime = metav1.NewTime(time.Now())
+		*existingConditions = append(*existingConditions, newCondition)
+
+		return newCondition
+	}
+
+	if existingCondition.Status != newCondition.Status ||
+		existingCondition.Reason != newCondition.Reason {
+		existingCondition.Status = newCondition.Status
+		existingCondition.Reason = newCondition.Reason
+		existingCondition.LastTransitionTime = metav1.NewTime(time.Now())
+	}
+
+	defaultValue := "none"
+	if newCondition.Reason == "" {
+		newCondition.Reason = defaultValue
+	}
+
+	if newCondition.Message == "" {
+		newCondition.Message = defaultValue
+	}
+
+	existingCondition.Reason = newCondition.Reason
+	existingCondition.Message = newCondition.Message
+	// TODO: Why not update lastTranTime if the above change?
+
+	if existingCondition.ObservedGeneration != newCondition.ObservedGeneration {
+		existingCondition.LastTransitionTime = metav1.NewTime(time.Now())
+	}
+
+	return *existingCondition
+}

internal/controller/volumereplicationgroup_controller.go

@@ -579,6 +579,16 @@ func (v *VRGInstance) processVRG() ctrl.Result {
 
 	v.log.Info("Recipe", "elements", v.recipeElements)
 
+	if err := recipeVMBackupValidate(v.ctx, v.reconciler.Client, v.recipeElements,
+		*v.instance, *v.ramenConfig, v.log); err != nil {
+		return v.invalid(
+			err,
+			"Velero misconfiguration detected; disaster recovery for the VM workload will not succeed. "+
+				"Verify Velero configuration and enable the required plugins",
+			false,
+		)
+	}
+
 	if err := v.updatePVCList(); err != nil {
 		return v.invalid(err, "Failed to process list of PVCs to protect", true)
 	}