Skip to content

Commit

Permalink
Bump the required Eigen version to 3.4
Browse files Browse the repository at this point in the history 
Relates #746
  • Loading branch information
@RainerKuemmerle
RainerKuemmerle committed Dec 6, 2023
1 parent 5db17af commit ef2c40d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${g2o_C_FLAGS}")
# Find Eigen3. If it defines the target, this is used. If not,
# fall back to the using the module form.
# See https://eigen.tuxfamily.org/dox/TopicCMakeGuide.html for details
find_package(Eigen3 3.3 REQUIRED)
find_package(Eigen3 3.4 REQUIRED)
if (TARGET Eigen3::Eigen)
set(G2O_EIGEN3_EIGEN_TARGET Eigen3::Eigen)
else()
Expand Down

2 comments on commit ef2c40d

@miquelmassot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now conflicting with CIBuildWheels for the g2o-python wrapper. The base OS for manylinux is CentOS7 and the default version for Eigen is 3.3.7. Any chance to lower this requirement?

@RainerKuemmerle
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miquelmassot Trying to lower this in #758 We can continue discussion in there if needed.

Please sign in to comment.