Skip to content

Commit

Permalink
Use strJoin instead of fmt::join
Browse files Browse the repository at this point in the history
Fix #825
  • Loading branch information
RainerKuemmerle committed Aug 13, 2024
1 parent 5e816df commit b6ebf6f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions g2o/core/optimizable_graph.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -473,14 +473,14 @@ bool OptimizableGraph::load(istream& is) {
}
if (!vertsOkay) {
G2O_ERROR("Unable to find vertices for edge {} at line {} IDs: {}",
token, lineNumber, fmt::join(ids, " "));
token, lineNumber, strJoin(ids.begin(), ids.end(), " "));
delete e;
e = nullptr;
} else {
bool r = e->read(currentLine);
if (!r || !addEdge(e)) {
G2O_ERROR("Unable to add edge {} at line {} IDs: {}", token,
lineNumber, fmt::join(ids, " "));
lineNumber, strJoin(ids.begin(), ids.end(), " "));
delete e;
e = nullptr;
}
Expand Down

1 comment on commit b6ebf6f

@EndlessPeak
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there are also fmt::join statements on lines 811 and 814. Should you consider replacing those as well?

Please sign in to comment.