Fix handling of already assigned PCI devices #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assign() raises DeviceAlreadyAssigned exception, not DeviceAlreadyAttached. While at it, fix reporting changed devices (report no change if nothing was changed), and also skip re-assigning if options didn't change.
This was referenced Apr 9, 2025
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025041016-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 8 fixed
Unstable testsPerformance TestsPerformance degradation:26 performance degradations
Remaining performance tests:46 tests
|
This was referenced Apr 9, 2025
Stop pretending qubes API uses BDF directly, as now with conversion to PCI paths it's not plausible anymore. And with a change in grains to list qubes's API identifiers it's not matching anymore anyway. But more importantly, using consistent identifiers is important if device need to have options changed, as the "old" device id need to match the "new" one - otherwise removing old one from list of assigned devices (value_combined variable) would fail. QubesOS/qubes-issues#8681
This was referenced Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assign() raises DeviceAlreadyAssigned exception, not
DeviceAlreadyAttached. While at it, fix reporting changed devices
(report no change if nothing was changed), and also skip re-assigning if
options didn't change.