-
-
Notifications
You must be signed in to change notification settings - Fork 115
Reproduce bug in qrexec tests #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The qrexec tests are broken and fail intermittently. This patch makes the bug obvious: by adding a sleep, it causes the test to fail right away, reliably.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
- Coverage 69.79% 69.72% -0.07%
==========================================
Files 58 58
Lines 12546 12546
==========================================
- Hits 8756 8748 -8
- Misses 3790 3798 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025041215-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests37 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 9 fixed
Unstable testsPerformance TestsPerformance degradation:16 performance degradations
Remaining performance tests:56 tests
|
|
I don't see any failure with this PR (but not QubesOS/qubes-core-qrexec#186): https://openqa.qubes-os.org/tests/129865 |
|
I finally got the correct stderr logged (#670, https://github.com/QubesOS/qubes-core-qrexec/pull/196/files) and got this: It's a progress I guess... |
|
Ok, this is clearly bug in tests - they create rpc services without shebang, so it works only when called via shell - which not always is the case. |
|
Fix: #675 |
The qrexec tests are broken and fail intermittently. This patch makes the bug obvious: by adding a sleep, it causes the test to fail right away, reliably.