Skip to content

Conversation

@marmarek
Copy link
Member

Otherwise all values would be serialized to str.

Otherwise all values would be serialized to str.
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.51%. Comparing base (26ae94d) to head (7279dbc).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   70.51%   70.51%           
=======================================
  Files          61       61           
  Lines       13312    13313    +1     
=======================================
+ Hits         9387     9388    +1     
  Misses       3925     3925           
Flag Coverage Δ
unittests 70.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Jun 20, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025062509-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win10_seamless@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
  • system_tests_qwt_win11@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Explorer-new-...
  • system_tests_basic_vm_qrexec_gui_ext4

Failed tests

8 failures
  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win10_seamless@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
  • system_tests_qwt_win11@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Explorer-new-...
  • system_tests_basic_vm_qrexec_gui_ext4

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

11 fixed

Unstable tests

Performance Tests

Performance degradation:

6 performance degradations
  • debian-12-xfce_exec-data-duplex-root: 90.83 🔺 ( previous job: 70.01, degradation: 129.74%)
  • whonix-gateway-17_socket-root: 9.29 🔺 ( previous job: 7.89, degradation: 117.69%)
  • whonix-workstation-17_exec-data-duplex-root: 98.57 🔺 ( previous job: 86.00, degradation: 114.62%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 221545.00 :small_red_triangle: ( previous job: 289982.00, degradation: 76.40%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 5961.00 :small_red_triangle: ( previous job: 8874.00, degradation: 67.17%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3764.00 :small_red_triangle: ( previous job: 4420.00, degradation: 85.16%)

Remaining performance tests:

66 tests
  • debian-12-xfce_exec: 8.33 🟢 ( previous job: 8.63, improvement: 96.54%)
  • debian-12-xfce_exec-root: 28.68 🟢 ( previous job: 29.44, improvement: 97.42%)
  • debian-12-xfce_socket: 8.19 🟢 ( previous job: 8.50, improvement: 96.32%)
  • debian-12-xfce_socket-root: 8.71 🔺 ( previous job: 8.31, degradation: 104.77%)
  • debian-12-xfce_exec-data-simplex: 67.31 🔺 ( previous job: 65.51, degradation: 102.75%)
  • debian-12-xfce_exec-data-duplex: 73.59 🔺 ( previous job: 73.55, degradation: 100.06%)
  • debian-12-xfce_socket-data-duplex: 154.32 🟢 ( previous job: 161.35, improvement: 95.64%)
  • fedora-42-xfce_exec: 9.09
  • fedora-42-xfce_exec-root: 61.09
  • fedora-42-xfce_socket: 8.42
  • fedora-42-xfce_socket-root: 8.25
  • fedora-42-xfce_exec-data-simplex: 76.47
  • fedora-42-xfce_exec-data-duplex: 77.03
  • fedora-42-xfce_exec-data-duplex-root: 99.06
  • fedora-42-xfce_socket-data-duplex: 130.39
  • whonix-gateway-17_exec: 6.65 🟢 ( previous job: 7.34, improvement: 90.55%)
  • whonix-gateway-17_exec-root: 39.06 🟢 ( previous job: 39.57, improvement: 98.70%)
  • whonix-gateway-17_socket: 8.50 🔺 ( previous job: 7.85, degradation: 108.18%)
  • whonix-gateway-17_exec-data-simplex: 80.12 🔺 ( previous job: 77.76, degradation: 103.04%)
  • whonix-gateway-17_exec-data-duplex: 76.17 🟢 ( previous job: 78.39, improvement: 97.18%)
  • whonix-gateway-17_exec-data-duplex-root: 92.70 🔺 ( previous job: 90.74, degradation: 102.16%)
  • whonix-gateway-17_socket-data-duplex: 169.29 🔺 ( previous job: 161.95, degradation: 104.53%)
  • whonix-workstation-17_exec: 8.01 🟢 ( previous job: 8.27, improvement: 96.74%)
  • whonix-workstation-17_exec-root: 53.37 🟢 ( previous job: 57.61, improvement: 92.64%)
  • whonix-workstation-17_socket: 8.92 🟢 ( previous job: 8.97, improvement: 99.51%)
  • whonix-workstation-17_socket-root: 8.56 🟢 ( previous job: 9.46, improvement: 90.50%)
  • whonix-workstation-17_exec-data-simplex: 72.79 🟢 ( previous job: 74.54, improvement: 97.65%)
  • whonix-workstation-17_exec-data-duplex: 77.27 🔺 ( previous job: 74.84, degradation: 103.24%)
  • whonix-workstation-17_socket-data-duplex: 165.43 🔺 ( previous job: 160.20, degradation: 103.27%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 275868.00 :green_circle: ( previous job: 101988.00, improvement: 270.49%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 102174.00 :green_circle: ( previous job: 14284.00, improvement: 715.30%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 99280.00 :green_circle: ( previous job: 32696.00, improvement: 303.65%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 102413.00 :green_circle: ( previous job: 17102.00, improvement: 598.84%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5363.00 :green_circle: ( previous job: 1091.00, improvement: 491.57%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 10166.00 :small_red_triangle: ( previous job: 11086.00, degradation: 91.70%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4133.00 :green_circle: ( previous job: 1840.00, improvement: 224.62%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 366378.00 :green_circle: ( previous job: 289182.00, improvement: 126.69%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 273280.00 :green_circle: ( previous job: 122848.00, improvement: 222.45%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 429568.00 :small_red_triangle: ( previous job: 433654.00, degradation: 99.06%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 169031.00 :green_circle: ( previous job: 167872.00, improvement: 100.69%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 107073.00 :small_red_triangle: ( previous job: 108760.00, degradation: 98.45%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7820.00 :green_circle: ( previous job: 6356.00, improvement: 123.03%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 379781.00
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 150072.00
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 294461.00
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 68993.00
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 94527.00
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2547.00
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8459.00
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1203.00
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 386643.00
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 201645.00
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 337054.00
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 62379.00
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 87789.00
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2779.00
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8825.00
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1368.00
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 337705.00
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 131381.00
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 343570.00
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 24063.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 83874.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2870.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8234.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1231.00

marmarek added a commit to marmarek/qubes-core-admin-client that referenced this pull request Jun 20, 2025
After QubesOS/qubes-core-admin#689 the type of
the 'xid' property is preserved and it's int now. Fix pacat daemon
parameters to convert it back to string.
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this pull request Jun 20, 2025
After QubesOS/qubes-core-admin#689 the type of
the 'xid' property is preserved and it's int now. Fix pacat daemon
parameters to convert it back to string.
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this pull request Jun 20, 2025
After QubesOS/qubes-core-admin#689 the type of
the 'xid' property is preserved and it's int now. Fix pacat daemon
parameters to convert it back to string.
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this pull request Jun 21, 2025
After QubesOS/qubes-core-admin#689 the type of
the 'xid' property is preserved and it's int now. Fix pacat daemon
parameters to convert it back to string.
@marmarek marmarek merged commit e6d9670 into QubesOS:main Jun 26, 2025
4 of 5 checks passed
@marmarek marmarek deleted the propery-type branch July 19, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants