Fix starting audio daemon #367

marmarek · 2025-06-20T09:40:53Z

After QubesOS/qubes-core-admin#689 the type of
the 'xid' property is preserved and it's int now. Fix pacat daemon
parameters to convert it back to string.

codecov · 2025-06-20T11:25:44Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.12%. Comparing base (50fe800) to head (ced1d2f).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
qubesadmin/tools/qvm_start_daemon.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files          53       53           
  Lines        9204     9204           
=======================================
  Hits         7007     7007           
  Misses       2197     2197

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

qubesos-bot · 2025-06-20T15:57:32Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025062011-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

system_tests_extra
- TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
  ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
system_tests_dispvm
- TC_20_DispVM_debian-12-xfce: test_013_dvm_run_preload_gui (failure)
  ^... AssertionError: None is not true
- TC_20_DispVM_fedora-42-xfce: test_013_dvm_run_preload_gui (failure)
  ^... AssertionError: None is not true
- TC_20_DispVM_fedora-42-xfce: test_015_dvm_run_preload_race_more (failure)
  ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^... AssertionError: False is not true
- TC_20_DispVM_whonix-workstation-17: test_013_dvm_run_preload_gui (failure)
  ^... AssertionError: None is not true
system_tests_audio@hw1
- TC_20_AudioVM_PipeWire_fedora-42-xfce: test_260_audio_mic_enabled_switch_audiovm (failure)
  AssertionError: no source-output found in test-inst-audiovm
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_qwt_win11@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'personal-text-editor'...
system_tests_basic_vm_qrexec_gui_ext4
- TC_20_NonAudio_whonix-workstation-17-pool: test_012_qubes_desktop_run (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError

Failed tests

14 failures

system_tests_extra
- TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
  ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
- TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
  AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
system_tests_dispvm
- TC_20_DispVM_debian-12-xfce: test_013_dvm_run_preload_gui (failure)
  ^... AssertionError: None is not true
- TC_20_DispVM_fedora-42-xfce: test_013_dvm_run_preload_gui (failure)
  ^... AssertionError: None is not true
- TC_20_DispVM_fedora-42-xfce: test_015_dvm_run_preload_race_more (failure)
  ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^... AssertionError: False is not true
- TC_20_DispVM_whonix-workstation-17: test_013_dvm_run_preload_gui (failure)
  ^... AssertionError: None is not true
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...
system_tests_audio@hw1
- TC_20_AudioVM_PipeWire_fedora-42-xfce: test_260_audio_mic_enabled_switch_audiovm (failure)
  AssertionError: no source-output found in test-inst-audiovm
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_qwt_win11@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'personal-text-editor'...
system_tests_basic_vm_qrexec_gui_ext4
- TC_20_NonAudio_whonix-workstation-17-pool: test_012_qubes_desktop_run (error + cleanup)
  raise TimeoutError from exc_val... TimeoutError

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

system_tests_splitgpg
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_extra
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_audio
- TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
  AssertionError: only silence detected, no useful audio data
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
  AssertionError: too short audio, expected 10s, got 7.95233560090703...
system_tests_guivm_vnc_gui_interactive
- simple_gui_apps: unnamed test (unknown)
- simple_gui_apps: Failed (test died)
  # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

Unstable tests

Performance Tests

Performance degradation:

4 performance degradations

debian-12-xfce_socket-root: 9.31 🔺 ( previous job: 8.31, degradation: 112.00%)
dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 12960.00 :small_red_triangle: ( previous job: 17102.00, degradation: 75.78%)
dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 88862.00 :small_red_triangle: ( previous job: 122848.00, degradation: 72.33%)
dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 7198.00 :small_red_triangle: ( previous job: 8874.00, degradation: 81.11%)

Remaining performance tests:

68 tests

debian-12-xfce_exec: 5.59 🟢 ( previous job: 8.63, improvement: 64.78%)
debian-12-xfce_exec-root: 29.18 🟢 ( previous job: 29.44, improvement: 99.14%)
debian-12-xfce_socket: 8.18 🟢 ( previous job: 8.50, improvement: 96.23%)
debian-12-xfce_exec-data-simplex: 72.01 🔺 ( previous job: 65.51, degradation: 109.92%)
debian-12-xfce_exec-data-duplex: 68.85 🟢 ( previous job: 73.55, improvement: 93.62%)
debian-12-xfce_exec-data-duplex-root: 69.70 🟢 ( previous job: 70.01, improvement: 99.56%)
debian-12-xfce_socket-data-duplex: 146.61 🟢 ( previous job: 161.35, improvement: 90.86%)
fedora-42-xfce_exec: 9.36
fedora-42-xfce_exec-root: 58.80
fedora-42-xfce_socket: 8.72
fedora-42-xfce_socket-root: 7.64
fedora-42-xfce_exec-data-simplex: 77.30
fedora-42-xfce_exec-data-duplex: 69.98
fedora-42-xfce_exec-data-duplex-root: 107.60
fedora-42-xfce_socket-data-duplex: 137.69
whonix-gateway-17_exec: 7.06 🟢 ( previous job: 7.34, improvement: 96.13%)
whonix-gateway-17_exec-root: 40.40 🔺 ( previous job: 39.57, degradation: 102.08%)
whonix-gateway-17_socket: 8.41 🔺 ( previous job: 7.85, degradation: 107.10%)
whonix-gateway-17_socket-root: 7.74 🟢 ( previous job: 7.89, improvement: 98.08%)
whonix-gateway-17_exec-data-simplex: 78.96 🔺 ( previous job: 77.76, degradation: 101.54%)
whonix-gateway-17_exec-data-duplex: 78.75 🔺 ( previous job: 78.39, degradation: 100.47%)
whonix-gateway-17_exec-data-duplex-root: 78.05 🟢 ( previous job: 90.74, improvement: 86.02%)
whonix-gateway-17_socket-data-duplex: 149.95 🟢 ( previous job: 161.95, improvement: 92.59%)
whonix-workstation-17_exec: 7.86 🟢 ( previous job: 8.27, improvement: 95.00%)
whonix-workstation-17_exec-root: 54.04 🟢 ( previous job: 57.61, improvement: 93.80%)
whonix-workstation-17_socket: 8.63 🟢 ( previous job: 8.97, improvement: 96.19%)
whonix-workstation-17_socket-root: 8.72 🟢 ( previous job: 9.46, improvement: 92.18%)
whonix-workstation-17_exec-data-simplex: 71.88 🟢 ( previous job: 74.54, improvement: 96.44%)
whonix-workstation-17_exec-data-duplex: 70.20 🟢 ( previous job: 74.84, improvement: 93.81%)
whonix-workstation-17_exec-data-duplex-root: 85.53 🟢 ( previous job: 86.00, improvement: 99.45%)
whonix-workstation-17_socket-data-duplex: 142.19 🟢 ( previous job: 160.20, improvement: 88.76%)
dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 357997.00 :green_circle: ( previous job: 289982.00, improvement: 123.45%)
dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 106809.00 :green_circle: ( previous job: 101988.00, improvement: 104.73%)
dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 110072.00 :green_circle: ( previous job: 14284.00, improvement: 770.60%)
dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 42482.00 :green_circle: ( previous job: 32696.00, improvement: 129.93%)
dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 7630.00 :green_circle: ( previous job: 1091.00, improvement: 699.36%)
dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 11416.00 :green_circle: ( previous job: 11086.00, improvement: 102.98%)
dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1977.00 :green_circle: ( previous job: 1840.00, improvement: 107.45%)
dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 408801.00 :green_circle: ( previous job: 289182.00, improvement: 141.36%)
dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 442997.00 :green_circle: ( previous job: 433654.00, improvement: 102.15%)
dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 197771.00 :green_circle: ( previous job: 167872.00, improvement: 117.81%)
dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 104672.00 :small_red_triangle: ( previous job: 108760.00, degradation: 96.24%)
dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7960.00 :green_circle: ( previous job: 6356.00, improvement: 125.24%)
dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4370.00 :small_red_triangle: ( previous job: 4420.00, degradation: 98.87%)
fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 348479.00
fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 91540.00
fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 318909.00
fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 44344.00
fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 86390.00
fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1810.00
fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8963.00
fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1818.00
fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 361702.00
fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 110155.00
fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 315361.00
fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 75639.00
fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 82149.00
fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 1424.00
fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8745.00
fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 863.00
fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 322341.00
fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 81028.00
fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 299678.00
fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 17463.00
fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 82116.00
fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 3687.00
fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8411.00
fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1539.00

After QubesOS/qubes-core-admin#689 the type of the 'xid' property is preserved and it's int now. Fix pacat daemon parameters to convert it back to string.

marmarek mentioned this pull request Jun 20, 2025

Late GUID for preloaded disposables #359

Merged

marmarek added the openqa-group-1 label Jun 20, 2025

marmarek force-pushed the xid-int branch 2 times, most recently from 550b8ce to 7c3a8d1 Compare June 20, 2025 10:59

Fix starting audio daemon

ced1d2f

After QubesOS/qubes-core-admin#689 the type of the 'xid' property is preserved and it's int now. Fix pacat daemon parameters to convert it back to string.

marmarek force-pushed the xid-int branch from e5fff88 to ced1d2f Compare June 21, 2025 09:26

marmarek merged commit ced1d2f into QubesOS:main Jun 21, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix starting audio daemon #367

Fix starting audio daemon #367

Uh oh!

marmarek commented Jun 20, 2025

Uh oh!

codecov bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

qubesos-bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Fix starting audio daemon #367

Fix starting audio daemon #367

Uh oh!

Conversation

marmarek commented Jun 20, 2025

Uh oh!

codecov bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qubesos-bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jun 20, 2025 •

edited

Loading

qubesos-bot commented Jun 20, 2025 •

edited

Loading