Enabling Ruff as code linter

.github/workflows/ci.yml

@@ -31,6 +31,7 @@ jobs:
       - name: Run lint
         run: |
           python -m black --check .
+          python -m ruff check
           python tools/verify_images.py
       - name: Build documentation
         uses: ./.github/actions/build-docs

ai-clifford-synthesis-demo.ipynb

@@ -19,10 +19,10 @@
     "import numpy as np\n",
     "from qiskit import QuantumCircuit\n",
     "from qiskit.quantum_info import random_clifford\n",
-    "\n",
     "from qiskit.transpiler import PassManager\n",
-    "from qiskit_ibm_transpiler.ai.synthesis import AICliffordSynthesis\n",
-    "from qiskit_ibm_transpiler.ai.collection import CollectCliffords"
+    "\n",
+    "from qiskit_ibm_transpiler.ai.collection import CollectCliffords\n",
+    "from qiskit_ibm_transpiler.ai.synthesis import AICliffordSynthesis"
    ]
   },
   {

ai-linear-function-synthesis-demo.ipynb

@@ -19,10 +19,10 @@
     "import numpy as np\n",
     "from qiskit import QuantumCircuit\n",
     "from qiskit.quantum_info import random_clifford\n",
-    "\n",
     "from qiskit.transpiler import PassManager\n",
-    "from qiskit_ibm_transpiler.ai.synthesis import AILinearFunctionSynthesis\n",
-    "from qiskit_ibm_transpiler.ai.collection import CollectLinearFunctions"
+    "\n",
+    "from qiskit_ibm_transpiler.ai.collection import CollectLinearFunctions\n",
+    "from qiskit_ibm_transpiler.ai.synthesis import AILinearFunctionSynthesis"
    ]
   },
   {

ai-permutation-synthesis-demo.ipynb

@@ -17,10 +17,11 @@
    "outputs": [],
    "source": [
     "from qiskit import QuantumCircuit\n",
+    "from qiskit.circuit.library import Permutation\n",
     "from qiskit.transpiler import PassManager\n",
+    "\n",
     "from qiskit_ibm_transpiler.ai.collection import CollectPermutations\n",
-    "from qiskit_ibm_transpiler.ai.synthesis import AIPermutationSynthesis\n",
-    "from qiskit.circuit.library import Permutation"
+    "from qiskit_ibm_transpiler.ai.synthesis import AIPermutationSynthesis"
    ]
   },
   {

documentation-examples.ipynb

@@ -16,6 +16,7 @@
    ],
    "source": [
     "from qiskit.circuit.library import EfficientSU2\n",
+    "\n",
     "from qiskit_ibm_transpiler.transpiler_service import TranspilerService\n",
     "\n",
     "circuit = EfficientSU2(101, entanglement=\"circular\", reps=1).decompose()\n",
@@ -44,6 +45,7 @@
    ],
    "source": [
     "from qiskit.circuit.library import EfficientSU2\n",
+    "\n",
     "from qiskit_ibm_transpiler.transpiler_service import TranspilerService\n",
     "\n",
     "circuit = EfficientSU2(101, entanglement=\"circular\", reps=1).decompose()\n",
@@ -72,6 +74,7 @@
    ],
    "source": [
     "from qiskit.circuit.library import EfficientSU2\n",
+    "\n",
     "from qiskit_ibm_transpiler.transpiler_service import TranspilerService\n",
     "\n",
     "circuit = EfficientSU2(101, entanglement=\"circular\", reps=1).decompose()\n",
@@ -100,6 +103,7 @@
    ],
    "source": [
     "from qiskit.circuit.library import EfficientSU2\n",
+    "\n",
     "from qiskit_ibm_transpiler.transpiler_service import TranspilerService\n",
     "\n",
     "circuit = EfficientSU2(101, entanglement=\"circular\", reps=1).decompose()\n",
@@ -118,9 +122,10 @@
    "metadata": {},
    "outputs": [],
    "source": [
+    "from qiskit.circuit.library import EfficientSU2\n",
     "from qiskit.transpiler import PassManager\n",
+    "\n",
     "from qiskit_ibm_transpiler.ai.routing import AIRouting\n",
-    "from qiskit.circuit.library import EfficientSU2\n",
     "\n",
     "ai_passmanager = PassManager(\n",
     "    [\n",
@@ -149,12 +154,12 @@
     }
    ],
    "source": [
+    "from qiskit.circuit.library import EfficientSU2\n",
     "from qiskit.transpiler import PassManager\n",
     "\n",
+    "from qiskit_ibm_transpiler.ai.collection import CollectLinearFunctions\n",
     "from qiskit_ibm_transpiler.ai.routing import AIRouting\n",
     "from qiskit_ibm_transpiler.ai.synthesis import AILinearFunctionSynthesis\n",
-    "from qiskit_ibm_transpiler.ai.collection import CollectLinearFunctions\n",
-    "from qiskit.circuit.library import EfficientSU2\n",
     "\n",
     "ai_passmanager = PassManager(\n",
     "    [\n",

local-mode-example.ipynb

@@ -6,12 +6,12 @@
    "metadata": {},
    "outputs": [],
    "source": [
+    "import numpy as np\n",
     "from qiskit import QuantumCircuit\n",
+    "from qiskit.quantum_info import random_clifford\n",
     "from qiskit.transpiler import PassManager, generate_preset_pass_manager\n",
-    "import numpy as np\n",
     "\n",
     "from qiskit_ibm_transpiler.ai.collection import CollectLinearFunctions\n",
-    "from qiskit.quantum_info import random_clifford\n",
     "from qiskit_ibm_transpiler.ai.synthesis import AILinearFunctionSynthesis"
    ]
   },

local-mode-routing.ipynb

@@ -6,9 +6,10 @@
    "metadata": {},
    "outputs": [],
    "source": [
+    "from qiskit.circuit.library import EfficientSU2\n",
     "from qiskit.transpiler import PassManager\n",
-    "from qiskit_ibm_transpiler.ai.routing import AIRouting\n",
-    "from qiskit.circuit.library import EfficientSU2"
+    "\n",
+    "from qiskit_ibm_transpiler.ai.routing import AIRouting"
    ]
   },
   {

qiskit_ibm_transpiler/__init__.py

@@ -10,12 +10,12 @@
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
 
+import logging
+
 from .ai import AIRouting
+from .ai_passmanager import generate_ai_pass_manager
 from .transpiler_service import TranspilerService
 from .utils import create_random_linear_function, get_metrics
-from .ai_passmanager import generate_ai_pass_manager
-
-import logging
 
 logging.basicConfig()
 logging.getLogger(__name__).addHandler(logging.NullHandler())

qiskit_ibm_transpiler/ai/collection.py

@@ -19,6 +19,7 @@
 from qiskit.circuit.barrier import Barrier
 from qiskit.circuit.library import LinearFunction, PermutationGate
 from qiskit.converters import circuit_to_dag, dag_to_dagdependency, dagdependency_to_dag
+from qiskit.dagcircuit.collect_blocks import BlockCollector
 from qiskit.dagcircuit.dagcircuit import DAGCircuit
 from qiskit.quantum_info.operators import Clifford
 from qiskit.transpiler.basepasses import TransformationPass
@@ -104,8 +105,6 @@ def run(self, dag: DAGCircuit):
 _flatten_permutations = Flatten(("permutation", "Permutation"))
 _flatten_paulinetworks = Flatten(("paulinetwork", "PauliNetwork"))
 
-from qiskit.dagcircuit.collect_blocks import BlockCollector
-
 
 class GreedyBlockCollector(BlockCollector):
     def __init__(self, dag, max_block_size):
@@ -212,7 +211,7 @@ def __init__(
         collect_from_back=False,
         num_reps=10,
     ):
-        collect_function = lambda dag: GreedyBlockCollector(
+        collect_function = lambda dag: GreedyBlockCollector(  # noqa:E731
             dag, max_block_size
         ).collect_all_matching_blocks(
             filter_fn=block_checker.select,

qiskit_ibm_transpiler/ai/routing.py

@@ -16,19 +16,19 @@
 # torch.set_num_threads(1)
 
 import importlib
-import numpy as np
 import logging
+from typing import List, Literal, Union
+
+import numpy as np
 from qiskit import ClassicalRegister, QuantumCircuit
 from qiskit.converters import circuit_to_dag, dag_to_circuit
+from qiskit.providers.backend import BackendV2 as Backend
 from qiskit.transpiler import CouplingMap, TranspilerError
 from qiskit.transpiler.basepasses import TransformationPass
 from qiskit.transpiler.layout import Layout
-from qiskit.providers.backend import BackendV2 as Backend
 from qiskit_ibm_runtime import QiskitRuntimeService
 
-from qiskit_ibm_transpiler.wrappers import AIRoutingAPI, AILocalRouting
-
-from typing import List, Union, Literal
+from qiskit_ibm_transpiler.wrappers import AILocalRouting, AIRoutingAPI
 
 logger = logging.getLogger(__name__)
 logger.setLevel(logging.INFO)

qiskit_ibm_transpiler/ai/synthesis.py

@@ -15,32 +15,30 @@
 import os
 from concurrent.futures import ThreadPoolExecutor, as_completed
 from multiprocessing import cpu_count
-from typing import Dict, Union, List
+from typing import Dict, List, Union
 
 from qiskit.circuit.exceptions import CircuitError
 from qiskit.converters import circuit_to_dag
 from qiskit.dagcircuit.dagcircuit import DAGCircuit
+from qiskit.providers.backend import BackendV2 as Backend
 from qiskit.quantum_info import Clifford
 from qiskit.transpiler import CouplingMap
 from qiskit.transpiler.basepasses import TransformationPass
 from qiskit.transpiler.exceptions import TranspilerError
-from qiskit.providers.backend import BackendV2 as Backend
 from qiskit_ibm_runtime import QiskitRuntimeService
 
 from qiskit_ibm_transpiler.wrappers import (
     AICliffordAPI,
     AILinearFunctionAPI,
-    AIPermutationAPI,
     AIPauliNetworkAPI,
+    AIPermutationAPI,
 )
-
 from qiskit_ibm_transpiler.wrappers.ai_local_synthesis import (
+    AILocalCliffordSynthesis,
     AILocalLinearFunctionSynthesis,
     AILocalPermutationSynthesis,
-    AILocalCliffordSynthesis,
 )
 
-
 logger = logging.getLogger(__name__)
 
 MAX_THREADS = os.environ.get("AI_TRANSPILER_MAX_THREADS", int(cpu_count() / 2))
@@ -383,7 +381,7 @@ def __init__(
         local_mode: bool = False,
         **kwargs,
     ) -> None:
-        if local_mode == True:
+        if local_mode == True:  # noqa:E712
             raise Exception(
                 "Pauli Network is not available locally, only in the Qiskit Transpiler Service"
             )

qiskit_ibm_transpiler/ai_passmanager.py

@@ -17,9 +17,9 @@
 from qiskit.transpiler import CouplingMap, PassManager
 from qiskit.transpiler.preset_passmanagers import generate_preset_pass_manager
 
+from .ai.collection import CollectLinearFunctions
 from .ai.routing import AIRouting
 from .ai.synthesis import AILinearFunctionSynthesis
-from .ai.collection import CollectLinearFunctions
 
 
 def generate_ai_pass_manager(

qiskit_ibm_transpiler/transpiler_service.py

@@ -27,7 +27,7 @@
 """
 
 import logging
-from typing import Dict, List, Union, Literal
+from typing import Dict, List, Literal, Union
 
 from qiskit import QuantumCircuit
 

qiskit_ibm_transpiler/utils.py

@@ -26,20 +26,19 @@
 
 """
 
-from typing import Dict, Union, List, Tuple
-from enum import Enum
-
-import numpy as np
-import logging
 import base64
 import io
+import logging
 import struct
+from enum import Enum
+from typing import Dict, List, Tuple, Union
 
+import numpy as np
 from qiskit import QuantumCircuit, qasm2, qasm3, qpy
+from qiskit.circuit import QuantumCircuit, library
 from qiskit.circuit.library import LinearFunction
 from qiskit.quantum_info import Clifford
 from qiskit.synthesis.linear.linear_matrix_utils import random_invertible_binary_matrix
-from qiskit.circuit import QuantumCircuit, library
 from qiskit.transpiler.basepasses import TransformationPass
 
 logger = logging.getLogger(__name__)
@@ -62,21 +61,14 @@ def random_permutation(n_qubits):
 
 
 def create_random_linear_function(n_qubits: int, seed: int = 123) -> LinearFunction:
-    rand_lin = lambda seed: LinearFunction(
-        random_invertible_binary_matrix(n_qubits, seed=seed)
-    )
-
-    return LinearFunction(rand_lin(seed))
+    return LinearFunction(random_invertible_binary_matrix(n_qubits, seed=seed))
 
 
 def random_clifford_from_linear_function(n_qubits: int, seed: int = 123):
     """Generate a random clifford from a random linear function of n_qubits qubits."""
 
-    random_linear = lambda seed: LinearFunction(
-        random_invertible_binary_matrix(n_qubits, seed=seed)
-    )
-    random_clifford = Clifford(random_linear(seed))
-    return random_clifford
+    random_linear = LinearFunction(random_invertible_binary_matrix(n_qubits, seed=seed))
+    return Clifford(random_linear)
 
 
 def to_qasm3_iterative_decomposition(circuit: QuantumCircuit, n_iter: int = 10):

qiskit_ibm_transpiler/wrappers/__init__.py

@@ -33,12 +33,12 @@
 """
 
 from .ai_api_routing import AIRoutingAPI
-from .ai_local_routing import AILocalRouting
 from .ai_api_synthesis import (
     AICliffordAPI,
     AILinearFunctionAPI,
-    AIPermutationAPI,
     AIPauliNetworkAPI,
+    AIPermutationAPI,
 )
+from .ai_local_routing import AILocalRouting
 from .base import BackendTaskError, QiskitTranspilerService
 from .transpile import TranspileAPI, _get_circuit_from_result

qiskit_ibm_transpiler/wrappers/ai_api_routing.py

@@ -10,17 +10,19 @@
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
 
+from typing import List, Literal, Union
+
 from qiskit import QuantumCircuit
+from qiskit.transpiler import CouplingMap
+
 from qiskit_ibm_transpiler.utils import (
     deserialize_circuit_from_qpy_or_qasm,
     get_circuit_from_qpy,
     get_qpy_from_circuit,
     serialize_circuit_to_qpy_or_qasm,
 )
-from .base import QiskitTranspilerService
-from typing import List, Union, Literal
-from qiskit.transpiler import CouplingMap
 
+from .base import QiskitTranspilerService
 
 # TODO: Reuse this code, it's repeated several times
 OptimizationOptions = Literal["n_cnots", "n_gates", "cnot_layers", "layers", "noise"]

qiskit_ibm_transpiler/wrappers/ai_api_synthesis.py

@@ -11,18 +11,18 @@
 # that they have been altered from the originals.
 
 import logging
-from typing import Union, List
+from typing import List, Union
 
 from qiskit import QuantumCircuit
 from qiskit.circuit.library import LinearFunction
-from qiskit.quantum_info import Clifford
 from qiskit.providers.backend import BackendV2 as Backend
+from qiskit.quantum_info import Clifford
 
-from .base import QiskitTranspilerService
 from ..utils import (
-    serialize_circuits_to_qpy_or_qasm,
     deserialize_circuit_from_qpy_or_qasm,
+    serialize_circuits_to_qpy_or_qasm,
 )
+from .base import QiskitTranspilerService
 
 logger = logging.getLogger(__name__)
 logger.setLevel(logging.INFO)

qiskit_ibm_transpiler/wrappers/ai_local_routing.py

@@ -11,11 +11,13 @@
 # that they have been altered from the originals.
 
 import importlib
+from typing import List, Literal, Union
+
 from qiskit import QuantumCircuit
-from qiskit_ibm_transpiler.utils import get_circuit_from_qasm, input_to_qasm
-from typing import List, Union, Literal
 from qiskit.transpiler import CouplingMap
 
+from qiskit_ibm_transpiler.utils import get_circuit_from_qasm, input_to_qasm
+
 ai_local_package = "qiskit_ibm_ai_local_transpiler"
 qiskit_ibm_ai_local_transpiler = (
     importlib.import_module(ai_local_package)