Fixes #151: org.junit.runner.Description.fAnnotations array is null with junitparams parameterized junit tests#158
Open
kompacher wants to merge 3 commits intoPragmatists:masterfrom
Open
Conversation
kompacher
changed the title
Author
|
The broken build has nothing to to with this PR. It is caused by the discontinued support of some older TLS versions: This should be fixed on a separate branch. |
kompacher
changed the title
kompacher
force-pushed
the
bugfix-151
branch
from
6219b2d to
a8e633a
Compare
Author
|
Dear @woprzech, did you have some time to review this pull request? |
vinaysshenoy
pushed a commit
to simpledotorg/simple-android
that referenced
this pull request
Mar 3, 2020
The main dependency has a bug where annotations added on test methods are not forwarded to any test rules (Pragmatists/JUnitParams#151), which breaks the `ExpectedUnsubscribed` annotation used for hinting to the `RxErrorsRule` that we expect a certain number of `Completable` instances to not be subscribed to. There is a PR to fix it (Pragmatists/JUnitParams#158), but this has been inactive for over a year, so I forked the repository and applied the fix myself and published it via Jitpack.
|
I forked the repository, applied the fix myself and published it via Jitpack. Repository: https://github.com/vinaysshenoy/JUnitParams |
vinaysshenoy
pushed a commit
to simpledotorg/simple-android
that referenced
this pull request
Mar 3, 2020
The main dependency has a bug where annotations added on test methods are not forwarded to any test rules (Pragmatists/JUnitParams#151), which breaks the `ExpectedUnsubscribed` annotation used for hinting to the `RxErrorsRule` that we expect a certain number of `Completable` instances to not be subscribed to. There is a PR to fix it (Pragmatists/JUnitParams#158), but this has been inactive for over a year, so I forked the repository and applied the fix myself and published it via Jitpack.
vinaysshenoy
pushed a commit
to simpledotorg/simple-android
that referenced
this pull request
Mar 3, 2020
The main dependency has a bug where annotations added on test methods are not forwarded to any test rules (Pragmatists/JUnitParams#151), which breaks the `ExpectedUnsubscribed` annotation used for hinting to the `RxErrorsRule` that we expect a certain number of `Completable` instances to not be subscribed to. There is a PR to fix it (Pragmatists/JUnitParams#158), but this has been inactive for over a year, so I forked the repository and applied the fix myself and published it via Jitpack.
vinaysshenoy
pushed a commit
to simpledotorg/simple-android
that referenced
this pull request
Mar 10, 2020
The main dependency has a bug where annotations added on test methods are not forwarded to any test rules (Pragmatists/JUnitParams#151), which breaks the `ExpectedUnsubscribed` annotation used for hinting to the `RxErrorsRule` that we expect a certain number of `Completable` instances to not be subscribed to. There is a PR to fix it (Pragmatists/JUnitParams#158), but this has been inactive for over a year, so I forked the repository and applied the fix myself and published it via Jitpack.
vinaysshenoy
pushed a commit
to simpledotorg/simple-android
that referenced
this pull request
Mar 19, 2020
The main dependency has a bug where annotations added on test methods are not forwarded to any test rules (Pragmatists/JUnitParams#151), which breaks the `ExpectedUnsubscribed` annotation used for hinting to the `RxErrorsRule` that we expect a certain number of `Completable` instances to not be subscribed to. There is a PR to fix it (Pragmatists/JUnitParams#158), but this has been inactive for over a year, so I forked the repository and applied the fix myself and published it via Jitpack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should reproduce and fix the issue described in #151. Looking forward for your feedback.