Skip to content

Commit 93b60d4

Browse files
author
Vinay S Shenoy
committed
Switch to alternate repository for JUnitParams
The main dependency has a bug where annotations added on test methods are not forwarded to any test rules (Pragmatists/JUnitParams#151), which breaks the `ExpectedUnsubscribed` annotation used for hinting to the `RxErrorsRule` that we expect a certain number of `Completable` instances to not be subscribed to. There is a PR to fix it (Pragmatists/JUnitParams#158), but this has been inactive for over a year, so I forked the repository and applied the fix myself and published it via Jitpack.
1 parent f236f51 commit 93b60d4

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

app/build.gradle

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ apply plugin: 'io.sentry.android.gradle'
99

1010
apply from: "../quality/install-git-hook.gradle"
1111

12-
repositories {
13-
maven { url 'https://jitpack.io' }
14-
}
15-
1612
sentry {
1713
autoProguardConfig true
1814
// We can disable auto upload of proguard mappings since we use -dontobfuscate when running proguard
@@ -212,7 +208,7 @@ dependencies {
212208

213209
testImplementation "junit:junit:$versions.junit"
214210
testImplementation "com.nhaarman:mockito-kotlin:$versions.mockitoKotlin"
215-
testImplementation "pl.pragmatists:JUnitParams:$versions.junitParams"
211+
testImplementation "com.github.vinaysshenoy:JUnitParams:$versions.junitParams"
216212
testImplementation "com.google.truth:truth:$versions.truth"
217213
testImplementation "com.github.blocoio:faker:$versions.faker"
218214

build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ buildscript {
4040
truth : '1.0',
4141
junit : '4.12',
4242
mockitoKotlin : '1.6.0',
43-
junitParams : '1.1.1',
43+
junitParams : '1.1.2',
4444
sqliteAndroid : '3.24.0',
4545
playServicesAuth : '16.0.1',
4646
playServicesVision : '16.2.0',
@@ -91,6 +91,7 @@ allprojects {
9191
repositories {
9292
google()
9393
mavenCentral()
94+
maven { url 'https://jitpack.io' }
9495
jcenter()
9596
}
9697
}

router/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ dependencies {
3030
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$versions.kotlin"
3131
implementation "io.reactivex.rxjava2:rxjava:$versions.rxJava"
3232
implementation "com.jakewharton.timber:timber:$versions.timber"
33-
testImplementation "pl.pragmatists:JUnitParams:$versions.junitParams"
33+
testImplementation "com.github.vinaysshenoy:JUnitParams:$versions.junitParams"
3434
testImplementation "com.google.truth:truth:$versions.truth"
3535
}
36-
repositories {
37-
mavenCentral()
38-
}

0 commit comments

Comments
 (0)