Skip to content

add some lint tools #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add some lint tools #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30c1d5c
add some lint tools
Plumezz Jul 17, 2025
251a8a1
fix the cpplint errors
Plumezz Jul 17, 2025
e6d55bf
fix the copyright errors
Plumezz Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions example_external/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,10 @@ install(

ament_export_targets(export_generate_parameter_library_example_external HAS_LIBRARY_TARGET)
ament_export_dependencies(rclcpp rclcpp_components generate_parameter_library_example)

if(BUILD_TESTING)
find_package(ament_lint_auto REQUIRED)
ament_lint_auto_find_test_dependencies()
endif()

ament_package()
7 changes: 6 additions & 1 deletion ...ternal/include/generate_parameter_library_example_external/minimal_publisher_external.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
// Copyright 2025 Forssea Robotics
//
// All rights reserved.
//
// Software License Agreement (BSD License 2.0)
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are met:
//
Expand Down Expand Up @@ -28,6 +32,7 @@

#pragma once

#include <memory>
#include <rclcpp/rclcpp.hpp>
#include <rclcpp_components/register_node_macro.hpp>

Expand All @@ -37,7 +42,7 @@ namespace admittance_controller {

class MinimalPublisher : public rclcpp::Node {
public:
MinimalPublisher(const rclcpp::NodeOptions& options = rclcpp::NodeOptions());
explicit MinimalPublisher(const rclcpp::NodeOptions& options = rclcpp::NodeOptions());

private:
void timer_callback();
Expand Down
6 changes: 5 additions & 1 deletion example_external/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@
<buildtool_export_depend>ament_cmake_core</buildtool_export_depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_lint_common</test_depend>
<test_depend>ament_cmake_lint_cmake</test_depend>
<test_depend>ament_cmake_cpplint</test_depend>
<test_depend>ament_cmake_cppcheck</test_depend>
<test_depend>ament_cmake_xmllint</test_depend>
<test_depend>ament_cmake_copyright</test_depend>

<export>
<build_type>ament_cmake</build_type>
Expand Down
4 changes: 4 additions & 0 deletions example_external/src/minimal_publisher_external.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
// Copyright 2025 Forssea Robotics
//
// All rights reserved.
//
// Software License Agreement (BSD License 2.0)
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are met:
//
Expand Down
Loading