Skip to content

add some lint tools #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add some lint tools #270

wants to merge 3 commits into from

Conversation

Plumezz
Copy link

@Plumezz Plumezz commented Jul 17, 2025

add some lint tools

@christophfroehlich
Copy link
Collaborator

Looks good, please also fix the linter errors now.

@Plumezz
Copy link
Author

Plumezz commented Jul 17, 2025

Sorry, I just fixed the cppllint errors. Now I have no idea about the copyright error,

@christophfroehlich
Copy link
Collaborator

It is missing the license type in the copyright claim
https://github.com/PickNikRobotics/generate_parameter_library/blob/main/example_external/src/minimal_publisher_external.cpp#L1
as the repo has BSD-3-Clause license, just add the missing lines like from here.

@Plumezz
Copy link
Author

Plumezz commented Jul 17, 2025

Ok, I tried to fix it.

@christophfroehlich
Copy link
Collaborator

Have you ran the tests locally? (pre-commit and colcon test?)

@Plumezz
Copy link
Author

Plumezz commented Jul 17, 2025

Sorry, I modified files in the original directory without adding lint tools. So there is no error in the output of command colcon test and I commit the changed files. Now I run colcon test again, it has the same lint copyright erroos.

Sorry for my careless PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant test dependencies in package.xml of generate_parameter_library_example_external
2 participants