Skip to content

Update flow-snapshot-worker-stateful-set.yaml #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update flow-snapshot-worker-stateful-set.yaml #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion peerdb/templates/flow-snapshot-worker-stateful-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,8 @@ spec:
{{- end }}
{{- with .Values.flowSnapshotWorker.resources }}
resources: {{ toYaml . | nindent 10 }}
{{- include "aws.config" . | nindent 8 }}
{{- include "catalog.pgConf" . | nindent 8 }}
{{- include "temporal.config" . | nindent 8 }}
Comment on lines +58 to +59
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is already present at line 50

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are two values. But the aws.config value is not there. This value should be included.
This value is for when I plan to use minio in my architecture.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make changes so that aws.config is with the rest of the env section and remove the duplicate values?

{{- end }}
{{- end -}}
{{- end -}}
Loading