Skip to content

Conversation

@sajjadjafaribojd
Copy link

🛠 Merge Request: Add missing configuration includes for Flow Snapshot Worker and bump chart versions
Summary
This merge request fixes the startup issue with the Flow Snapshot Worker in Kubernetes by adding missing configuration includes in the Helm chart, and also bumps the chart versions as required.
Fix Details
Added the following configuration includes under
peerdb-enterprise/peerdb/templates/flow-snapshot-worker-stateful-set.yaml:

{{- include "aws.config" . | nindent 8 }}
{{- include "catalog.pgConf" . | nindent 8 }}
{{- include "temporal.config" . | nindent 8 }}

These includes are necessary for:
MinIO access (aws.config)
PeerDB internal PostgreSQL catalog connection (catalog.pgConf)
Temporal configuration and connectivity (temporal.config)
Without them, the flow-snapshot-worker StatefulSet fails to start properly due to missing environment variables.
✅ Additional Updates (as requested)
Bumped both peerdb and peerdb-catalog chart versions according to semantic versioning.
Updated peerdb-catalog/values.yaml:
Set temporal.admintools.image.tag to match the correct version from the dependency in peerdb/Chart.yaml.
Result
After applying these changes:
The Flow Snapshot Worker now initializes successfully.
Chart versions and image tags are aligned with the project’s semantic versioning policy.

Fix missing configuration includes in flow-snapshot-worker-stateful-set.yaml
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment on lines +58 to +59
{{- include "catalog.pgConf" . | nindent 8 }}
{{- include "temporal.config" . | nindent 8 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is already present at line 50

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are two values. But the aws.config value is not there. This value should be included.
This value is for when I plan to use minio in my architecture.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make changes so that aws.config is with the rest of the env section and remove the duplicate values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants