Conversation
Because this older version fails to install on Ubuntu 20.04 and makes the entire setup script fail.
This can lead to inconsistency with the installed package. E.g. also if the package is remove the upgraded pip stays but the symbolic links are gone.
to avoid downloading and installing ARM GCC again if the script is reran immediately after e.g. because it failed the first time.
That makes gazebo crash in VMWare 3D graphics accelration.
Contributor
|
FWIW (since I can't merge) looks good to me. |
dagar
approved these changes
Jun 29, 2020
Member
|
Looks good. I still want to get this into the containers to keep everything synced nicely. PX4/PX4-containers#267 |
Contributor
|
This creates a warning for me: |
Member
Author
@julianoes In docker? With normal Ubuntu 20.04 desktop it's preinstalled. Maybe I need to add it for minimal/docker cases. |
MaEtUgR
added a commit
that referenced
this pull request
Jul 21, 2020
On normal desktop distributions dmidecode is preinstalled and I was assuming it's part of the core tools. Thanks to a hint #15241 (comment) I found out it's not and am installing the package before using it.
Member
Author
|
@julianoes I added the package now before I forget: #15388 |
dagar
pushed a commit
that referenced
this pull request
Jul 21, 2020
On normal desktop distributions dmidecode is preinstalled and I was assuming it's part of the core tools. Thanks to a hint #15241 (comment) I found out it's not and am installing the package before using it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
I set up a new Ubuntu 20.04 VM and ran into a bunch of issues. I made some changes to the setup script to avoid all of them.
Describe your solution
The commit messages clearly describe the steps.
Test data / coverage
I retested the changes after resetting the VM to a snapshot just after installation.
Additional context
The additional python package requirement for matplotlib with an exact old version added in #15203 was the main reason the script failed on 20.04.