tests/tcg/ppc64: Add mffsce test #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcoracolombo
force-pushed
the
vccolombo-mffsce-test
branch
2 times, most recently
from
44add9e to
7cf48eb
Compare
Add mffsce test to check both the return value and the new fpscr stored in the cpu. Signed-off-by: Víctor Colombo <[email protected]>
vcoracolombo
force-pushed
the
vccolombo-mffsce-test
branch
from
7cf48eb to
b8e86c9
Compare
luporl
reviewed
May 3, 2022
luporl
left a comment
luporl
left a comment
There was a problem hiding this comment.
Looks good.
I'm a bit worried about using binary constants, but otherwise I have only a few nitpicks.
luporl
approved these changes
May 10, 2022
mferst
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mffsce test to check both the return value and the new fpscr
stored in the cpu.
Signed-off-by: Víctor Colombo [email protected]
I though I had found a bug in mffsce while I was reading the code, but it wasn't the case
so, let's contribute the test I had to write as it is already done? :)