Skip to content

Conversation

@TheTechnician27
Copy link
Contributor

@TheTechnician27 TheTechnician27 commented Oct 17, 2025

Description of Changes

Automatically detects the user's timezone and DST when computing manual RTC date/time. Adds date/time information to the emulog on CDVD reset.

image image image

Rationale behind Changes

  • The current manual RTC implementation requires the user to set their BIOS timezone and DST to an assumed value of GMT+0 and Summer. There's no reason for this other than as a bodge when I didn't know how to access this information in the NVM file. This automatically accounts for whatever the timezone and DST is set to in the BIOS.
  • Having this information in the emulog for debugging, especially regarding RTC, could be useful in the future.

Suggested Testing Steps

  • Testing timezones and DST is rough to test because there's no global option for RTC, and thus the Start BIOS feature can't see this. The easiest option is to transfer the six values from a per-game .ini file into the global one under "EmuCore". I've tested this on my end with GMT+0, GMT+2, GMT+5:45, GMT-8, (edit: now GMT-3:30), etc.
  • Under the console log, the time information is in green text right after "Resetting host memory for virtual systems..." Make sure that the information comports with your setup. Timezone, DST, Date Format, and Time Format are what you have in your BIOS. System Time Basis is where PCSX2 is drawing the system time from. System time is what the system time should be on boot.

Did you use AI to help find, test, or implement this issue or feature?

No.

Copy link
Member

@TellowKrinkle TellowKrinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me but I haven't tested it

@TheTechnician27 TheTechnician27 added this to the Release 2.6 milestone Oct 17, 2025
@TheTechnician27 TheTechnician27 marked this pull request as draft October 17, 2025 13:05
@TheTechnician27 TheTechnician27 marked this pull request as ready for review October 17, 2025 17:32
@TheTechnician27 TheTechnician27 force-pushed the nvm branch 3 times, most recently from 8145460 to 0037a79 Compare October 17, 2025 17:43
@TheTechnician27 TheTechnician27 force-pushed the nvm branch 4 times, most recently from b464f34 to 0d9ab54 Compare October 18, 2025 16:34
@TheTechnician27
Copy link
Contributor Author

Latest push was just to flip the order the Time Format and Date Format are printed to comport with the order found in the BIOS menu. Nothing non-trivial.

@TheTechnician27
Copy link
Contributor Author

Latest pushes make it so that the time printed in the console matches the resulting system time. For example, the input time we send to CDVD doesn't necessarily match the RTC due to e.g. user BIOS settings (this is intentional). This was the last issue I knew of, as I initially wasn't sure whether to simply keep the input time instead of the resulting time. However, this is much more sensible and intuitive.

Copy link
Member

@JordanTheToaster JordanTheToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich hasse es, dass Zeitzonen eine Säule der modernen Gesellschaft sind.

@TheTechnician27 TheTechnician27 marked this pull request as draft October 18, 2025 23:56
@TheTechnician27 TheTechnician27 marked this pull request as ready for review October 19, 2025 00:23
@TheTechnician27 TheTechnician27 force-pushed the nvm branch 2 times, most recently from d8131f4 to 572ee79 Compare October 19, 2025 00:28
@TheTechnician27 TheTechnician27 force-pushed the nvm branch 3 times, most recently from 88482a2 to d0dbf45 Compare October 19, 2025 00:35
Copy link
Contributor

@SternXD SternXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

from a very light test seems to do what is described looking at system console

@TheTechnician27
Copy link
Contributor Author

Just added a few comments back that were destroyed accidentally in the merge conflict resolution. Nothing functional has changed.

@TheTechnician27 TheTechnician27 requested review from GovanifY, TheLastRar and chaoticgd and removed request for GovanifY and TheLastRar October 31, 2025 14:30
@TellowKrinkle TellowKrinkle merged commit b688117 into PCSX2:master Nov 11, 2025
12 checks passed
@TheTechnician27 TheTechnician27 removed the request for review from chaoticgd November 11, 2025 02:19
@TheTechnician27 TheTechnician27 deleted the nvm branch November 15, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants