-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RTC: Automatically detect timezone #13408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TellowKrinkle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me but I haven't tested it
8145460 to
0037a79
Compare
b464f34 to
0d9ab54
Compare
|
Latest push was just to flip the order the Time Format and Date Format are printed to comport with the order found in the BIOS menu. Nothing non-trivial. |
|
Latest pushes make it so that the time printed in the console matches the resulting system time. For example, the input time we send to CDVD doesn't necessarily match the RTC due to e.g. user BIOS settings (this is intentional). This was the last issue I knew of, as I initially wasn't sure whether to simply keep the input time instead of the resulting time. However, this is much more sensible and intuitive. |
JordanTheToaster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich hasse es, dass Zeitzonen eine Säule der modernen Gesellschaft sind.
d8131f4 to
572ee79
Compare
88482a2 to
d0dbf45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
97f64b0 to
c59ae66
Compare
|
Just added a few comments back that were destroyed accidentally in the merge conflict resolution. Nothing functional has changed. |

Description of Changes
Automatically detects the user's timezone and DST when computing manual RTC date/time. Adds date/time information to the emulog on CDVD reset.
Rationale behind Changes
Suggested Testing Steps
Start BIOSfeature can't see this. The easiest option is to transfer the six values from a per-game.inifile into the global one under "EmuCore". I've tested this on my end with GMT+0, GMT+2, GMT+5:45, GMT-8, (edit: now GMT-3:30), etc.Did you use AI to help find, test, or implement this issue or feature?
No.