RTC: Automatically detect timezone

Author: TheTechnician27

pcsx2-qt/Settings/EmulationSettingsWidget.cpp

@@ -159,9 +159,8 @@ EmulationSettingsWidget::EmulationSettingsWidget(SettingsWindow* settings_dialog
 	dialog()->registerWidgetHelp(m_ui.manuallySetRealTimeClock, tr("Manually Set Real-Time Clock"), tr("Unchecked"),
 		tr("Manually set a real-time clock to use for the virtual PlayStation 2 instead of using your OS' system clock."));
 	dialog()->registerWidgetHelp(m_ui.rtcDateTime, tr("Real-Time Clock"), tr("Current date and time"),
-		tr("Real-time clock (RTC) used by the virtual PlayStation 2. Date format is the same as the one used by your OS. "
-		   "This time is only applied upon booting the PS2; changing it while in-game will have no effect. "
-		   "NOTE: This assumes you have your PS2 set to the default timezone of GMT+0 and default DST of Summer Time. "
+		tr("Real-time clock (RTC) used by the virtual PlayStation 2. Date format is the same as the one used by your OS.<br>"
+		   "This time is only applied upon booting the PS2; changing it while in-game will have no effect.<br>"
 		   "Some games require an RTC date/time set after their release date."));
 
 	updateOptimalFramePacing();

pcsx2/CDVD/CDVD.cpp

@@ -920,25 +920,35 @@ void cdvdReset()
 	cdvd.ReadTime = cdvdBlockReadTime(MODE_DVDROM);
 	cdvd.RotSpeed = cdvdRotationTime(MODE_DVDROM);
 
+	ReadOSDConfigParames();
+
+	// Print timezone offset, DST, date format, and time format.
+	DevCon.WriteLn(Color_StrongGreen, configParams1.timezoneOffset < 0 ? "Timezone Offset: GMT%03d:%02d" : "Timezone Offset: GMT+%02d:%02d",
+				   configParams1.timezoneOffset / 60, std::abs(configParams1.timezoneOffset % 60));
+	DevCon.WriteLn(Color_StrongGreen, "DST: %s Time", GetDaylightSavings() ? "Summer" : "Winter");
+	DevCon.WriteLn(Color_StrongGreen, "Time Format: %s-Hour", GetTimeFormat() ? "12" : "24");
+ 	DevCon.WriteLn(Color_StrongGreen, "Date Format: %s", GetDateFormat() ? (GetDateFormat() == 2 ? "DD/MM/YYYY" : "MM/DD/YYYY") : "YYYY/MM/DD");
+
 	if (EmuConfig.ManuallySetRealTimeClock)
 	{
-		// Convert to GMT+9 (assumes GMT+0)
 		std::tm tm{};
 		tm.tm_sec = EmuConfig.RtcSecond;
 		tm.tm_min = EmuConfig.RtcMinute;
 		tm.tm_hour = EmuConfig.RtcHour;
 		tm.tm_mday = EmuConfig.RtcDay;
 		tm.tm_mon = EmuConfig.RtcMonth - 1;
 		tm.tm_year = EmuConfig.RtcYear + 100; // 2000 - 1900
-		tm.tm_isdst = 1;
+		tm.tm_isdst = 0; // unused but necessary filler
 
-		// Need this instead of mktime for timezone independence
+		// Need this instead of mktime for timezone independence.
 		std::time_t t = 0;
+
+		// Account for user timezone, DST, and GMT+9 defaultism.
 		#if defined(_WIN32)
-			t = _mkgmtime(&tm) + 32400; //60 * 60 * 9 for GMT+9
+			t = _mkgmtime(&tm) + 32400 - 60 * (configParams1.timezoneOffset + GetDaylightSavings() * 60);
 			gmtime_s(&tm, &t);
 		#else
-			t = timegm(&tm) + 32400;
+			t = timegm(&tm) + 32400 - 60 * (configParams1.timezoneOffset + GetDaylightSavings() * 60);
 			gmtime_r(&t, &tm);
 		#endif
 
@@ -983,6 +993,21 @@ void cdvdReset()
 		cdvd.RTC.year = static_cast<u8>(curtime.tm_year - 100); // offset from 2000
 	}
 
+	// Print system time and system time basis.
+	if (EmuConfig.ManuallySetRealTimeClock)
+	{
+		DevCon.WriteLn(Color_StrongGreen, "System Time Basis: Manual RTC");
+		DevCon.WriteLn(Color_StrongGreen, "System Time: 20%02u-%02u-%02u %02u:%02u:%02u",
+				  	   EmuConfig.RtcYear, EmuConfig.RtcMonth, EmuConfig.RtcDay,
+					   EmuConfig.RtcHour, EmuConfig.RtcMinute, EmuConfig.RtcSecond);
+	}
+	else
+	{
+		DevCon.WriteLn(Color_StrongGreen, "System Time Basis: %s", g_InputRecording.isActive() ? "Default Input Recording Time" : "Operating System Time");
+		DevCon.WriteLn(Color_StrongGreen, "System Time: 20%02u-%02u-%02u %02u:%02u:%02u",
+				  	   cdvd.RTC.year, cdvd.RTC.month, cdvd.RTC.day, cdvd.RTC.hour, cdvd.RTC.minute, cdvd.RTC.second);
+	}
+
 	cdvdCtrlTrayClose();
 }
 

pcsx2/Config.h

@@ -1314,7 +1314,7 @@ struct Pcsx2Config
 		InhibitScreensaver : 1,
 		BackupSavestate : 1,
 		McdFolderAutoManage : 1,
-		ManuallySetRealTimeClock : 1,
+		ManuallySetRealTimeClock : 1, // passes user-set real-time clock information to cdvd at startup
 
 		HostFs : 1,
 

pcsx2/ps2/BiosTools.cpp

@@ -382,3 +382,21 @@ void CopyBIOSToMemory()
 
 	CurrentBiosInformation.eeThreadListAddr = 0;
 }
+
+// Summer = True; Winter = False
+bool GetDaylightSavings()
+{
+	return configParams2.UC[1] & 0x10 ? true : false;
+}
+
+// 12-Hour = True; 24-Hour = False
+bool GetTimeFormat()
+{
+	return configParams2.UC[1] & 0x20 ? true : false;
+}
+
+// DD/MM/YYYY = 2; MM/DD/YYYY = 1; YYYY/MM/DD = 0
+u8 GetDateFormat()
+{
+	return configParams2.UC[1] & 0x80 ? 2 : (configParams2.UC[1] & 0x40 ? 1 : 0);
+}

pcsx2/ps2/BiosTools.h

@@ -43,7 +43,7 @@ typedef struct
 			/** LANGUAGE_??? value */
 			/*16*/ u32 language : 5;
 			/** timezone minutes offset from gmt */
-			/*21*/ u32 timezoneOffset : 11;
+			/*21*/ s32 timezoneOffset : 11;
 		};
 
 		u8  UC[4];
@@ -117,3 +117,7 @@ extern bool IsBIOSAvailable(const std::string& full_path);
 
 extern bool LoadBIOS();
 extern void CopyBIOSToMemory();
+
+extern bool GetDaylightSavings();
+extern bool GetTimeFormat();
+extern u8 GetDateFormat();