Skip to content

feat: add OpenVox View dashboard alongside Puppetboard#20

Open
sratslla wants to merge 2 commits intoOpenVoxProject:mainfrom
Obmondo:feature/openvoxview-alongside-puppetboard
Open

feat: add OpenVox View dashboard alongside Puppetboard#20
sratslla wants to merge 2 commits intoOpenVoxProject:mainfrom
Obmondo:feature/openvoxview-alongside-puppetboard

Conversation

@sratslla
Copy link

Fixes #19

Summary

  • Adds OpenVox View support to openvox-helm-chart as an additional optional dashboard (Option B), without removing existing Puppetboard support.
  • Introduces openvoxview.* values (image/tag/port/resources/env/ingress/securityContext) to enable/disable OpenVox View independently.
  • Deploys OpenVox View as a sidecar container in the PuppetDB pod, mounts PuppetDB certs, and exposes it via the PuppetDB service on port 5000.
  • Adds an optional openvoxview ingress template and helper labels.
  • Updates README with configuration and usage examples.

PR sponsored by Obmondo.com


Note: Since this is a company-paid contribution, we fork to the company account repo on GitHub. GitHub does not support "allow maintainer to edit in repo" for organization accounts.

  • Maintainers can either provide feedback for required changes before merging, OR
  • Pull our branch, make changes in their repo, and create a new PR including our commits.

Signed-off-by: Shubh Gaur <shubh@obmondo.com>
@sratslla
Copy link
Author

Just saw this PR missed it when I created the issue. We have implemented it in slightly different approach. Lemme know how you wanna take this forward.

@anthonysomerset
Copy link
Collaborator

I have to say i prefer this implementation method as it allows users the choice and allows us a transition path (e.g. leave puppetboard default, then switch to openvoxview as default, then later remove puppetboard)

@JGodin-C2C wanting to draw your attention to this for any input you may wish to add

I haven't reviewed yet but please ensure that default remains puppetboard at this time

Copy link
Collaborator

@anthonysomerset anthonysomerset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the change, please update the unit tests and bump the version number like other merged changes and push to this PR

@JGodin-C2C
Copy link
Contributor

Yep, overall the MR seems solid ( i left a comment, but that kinda splinting hairs ) .
For next improvement (in another MR ).

So, kudos for the new code.

@sratslla
Copy link
Author

I have made the suggested changes, please have a look.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request]: Add support for OpenVox View dashboard to Helm chart

3 participants