feat: add OpenVox View dashboard alongside Puppetboard#20
feat: add OpenVox View dashboard alongside Puppetboard#20sratslla wants to merge 2 commits intoOpenVoxProject:mainfrom
Conversation
Signed-off-by: Shubh Gaur <shubh@obmondo.com>
|
I have to say i prefer this implementation method as it allows users the choice and allows us a transition path (e.g. leave puppetboard default, then switch to openvoxview as default, then later remove puppetboard) @JGodin-C2C wanting to draw your attention to this for any input you may wish to add I haven't reviewed yet but please ensure that default remains puppetboard at this time |
anthonysomerset
left a comment
There was a problem hiding this comment.
I am happy with the change, please update the unit tests and bump the version number like other merged changes and push to this PR
|
Yep, overall the MR seems solid ( i left a comment, but that kinda splinting hairs ) .
So, kudos for the new code. |
|
I have made the suggested changes, please have a look. |
Fixes #19
Summary
PR sponsored by Obmondo.com
Note: Since this is a company-paid contribution, we fork to the company account repo on GitHub. GitHub does not support "allow maintainer to edit in repo" for organization accounts.