Skip to content

Remove remaining TODOs from com.ibm.ws.messaging.comms.client #34250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
volosied wants to merge 1 commit into
base: integration
Choose a base branch
from
+5 −14
Open

Remove remaining TODOs from com.ibm.ws.messaging.comms.client #34250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/CommsOutboundChain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2011, 2023 IBM Corporation and others.
* Copyright (c) 2011, 2026 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
Expand Down Expand Up @@ -256,7 +256,6 @@ private synchronized void createSecureJFAPChain(OutboundSecureFacet secureFacet)
}
}else {
// Use Netty Framework for transport
// TODO: Verify Dynamic updates with SSL on Netty
try {
if (null == secureFacet) throw new ChainException(new Throwable(nls.getFormattedMessage("missingSslOptions.ChainNotStarted", new Object[] { chainName }, "Chain not started " + chainName)));
if (isAnyTracingEnabled() && tc.isDebugEnabled()) debug(this, tc, "JFAP Outbound secure chain" + chainName + " successfully started ");
Expand Down
9 changes: 1 addition & 8 deletions ...ging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyNetworkConnectionContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2022, 2023 IBM Corporation and others.
* Copyright (c) 2022, 2026 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
Expand Down Expand Up @@ -102,13 +102,6 @@ public void close(NetworkConnection networkConnection, Throwable throwable)
if (TraceComponent.isAnyTracingEnabled() && tc.isEntryEnabled())
SibTr.entry(this, tc, "close", new Object[] { networkConnection, throwable });

// TODO: This needs to be verified and implemented is not. https://github.com/OpenLiberty/open-liberty/issues/24814
// If the server is stopping, all connections will be closed/flushed by netty bundle? Verify
if (FrameworkState.isStopping()) {
if (TraceComponent.isAnyTracingEnabled() && tc.isEntryEnabled())
SibTr.exit(this, tc, "close");
return;
}
Exception exception = null;
if (throwable instanceof Exception)
{
Expand Down
3 changes: 1 addition & 2 deletions ...ging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyNetworkConnectionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2022, 2023 IBM Corporation and others.
* Copyright (c) 2022, 2026 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
Expand Down Expand Up @@ -106,7 +106,6 @@ public NetworkConnection createConnection(Object endpoint) throws FrameworkExcep
{
if (tc.isEntryEnabled())
SibTr.entry(this, tc, "createConnection", endpoint);
// TODO: Verify if this is used. See https://github.com/OpenLiberty/open-liberty/issues/22692
throw new FrameworkException("Not implemented yet for Netty. Currently only used on tWAS not Liberty.");

}
Expand Down
4 changes: 2 additions & 2 deletions ....client/src/com/ibm/ws/sib/jfapchannel/richclient/framework/impl/RichClientFramework.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public Map getOutboundConnectionProperties(Object ep)
if (TraceComponent.isAnyTracingEnabled() && tc.isEntryEnabled())
SibTr.entry(this, tc, "getOutboundConnectionProperties", ep);

// TODO: Check if this data path is even used see https://github.com/OpenLiberty/open-liberty/issues/22692
// Note: No known code paths within Liberty

Map properties = null;
if (ep instanceof CFEndPoint)
Expand Down Expand Up @@ -542,4 +542,4 @@ public ClassLoader run() {
return endPoint;
}

}
}