Remove remaining TODOs from com.ibm.ws.messaging.comms.client#34250
Open
volosied wants to merge 1 commit intoOpenLiberty:integrationfrom
Open
Remove remaining TODOs from com.ibm.ws.messaging.comms.client#34250volosied wants to merge 1 commit intoOpenLiberty:integrationfrom
volosied wants to merge 1 commit intoOpenLiberty:integrationfrom
Conversation
Member
Author
|
!build (view Open Liberty Personal Build - ✅ completed successfully!) Note: Target locations of links might be accessible only to IBM employees. |
Member
Author
|
In Progress as of March 5th |
Member
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Member
|
!build Note: Target locations of links might be accessible only to IBM employees. |
Member
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).################################################################################################
fixes #25963
// TODO: Verify Dynamic updates with SSL on Netty// TODO: Verify if this is used. See https://github.com/OpenLiberty/open-liberty/issues/22692// TODO: This needs to be verified and implemented is not. https://github.com/OpenLiberty/open-liberty/issues/24814com.ibm.ws.jbatch.jms.throttle_fat's testThrottlingJobs where the messageEngineServer was shutdown during active connections.Connection unexpectedly broken during read.errors logged.There are other TODOs but they are not Netty related.
I didn't much improvement for Optionals, so I left it alone.