Skip to content

Remove remaining TODOs from com.ibm.ws.messaging.comms.client#34250

Open
volosied wants to merge 1 commit intoOpenLiberty:integrationfrom
volosied:fix-jms-todos
Open

Remove remaining TODOs from com.ibm.ws.messaging.comms.client#34250
volosied wants to merge 1 commit intoOpenLiberty:integrationfrom
volosied:fix-jms-todos

Conversation

@volosied
Copy link
Member

@volosied volosied commented Mar 4, 2026

################################################################################################

fixes #25963

// TODO: Verify Dynamic updates with SSL on Netty

  • Verified via keystore updates and saw the code path entered

// TODO: Verify if this is used. See https://github.com/OpenLiberty/open-liberty/issues/22692

  • Not implemented and no known tests enter that code

// TODO: This needs to be verified and implemented is not. https://github.com/OpenLiberty/open-liberty/issues/24814

  • The FrameworkState.isStopping() was removed.
  • Explicit closure during shutdown is cleaner than relying on Netty to forcibly terminate connections.
  • Testing was performed on com.ibm.ws.jbatch.jms.throttle_fat's testThrottlingJobs where the messageEngineServer was shutdown during active connections.
    • With the check included, I saw numerous Connection unexpectedly broken during read. errors logged.
    • With it removed, the connections were explicitly closed.

There are other TODOs but they are not Netty related.

I didn't much improvement for Optionals, so I left it alone.

@volosied
Copy link
Member Author

volosied commented Mar 4, 2026

!build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@volosied
Copy link
Member Author

volosied commented Mar 4, 2026

@LibbyBot
Copy link
Member

LibbyBot commented Mar 4, 2026

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@isaacrivriv
Copy link
Member

isaacrivriv commented Mar 6, 2026

!build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
command=ant -f build-test.xml localrun -propertyfile ../../../buildandbucket.properties -DhaltOnFailure=false -Dglobal.jvm.args="-Dcom.ibm.ws.beta.edition=true" -lib ../ant_build/lib.antClasspath

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link
Member

LibbyBot commented Mar 6, 2026

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Clean up JMS Netty

3 participants