Package updates & maintenance: remove jms/translations bundle #518
Conversation
johanib
force-pushed
the
feature/update_jan26
branch
2 times, most recently
from
eac2252 to
fe6a8f6
Compare
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
Nice work, see some concerns below
johanib
force-pushed
the
feature/update_jan26
branch
2 times, most recently
from
b2489a1 to
4d70e80
Compare
|
Thanks for the review @MKodde, might have been a bit short through the corner. I took a look at your feedback and made some improvements, please take a look. |
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
All is looking good! Save for one translation that was removed.
Please fix that. And could you also try'n fix the removed -> then created [ xliff -> xlif ] conversion? We are now losing the commit history for those files.
Remove deprecated jms/translation-bundle and with it the doctrine/annotations. From now on, translations should be edited manually or with an external tool.
Prior to this change, the XLIFF files used the .xliff extension. This change renames the XLIFF files to use the .xlf extension for standardization.
- Translations of unknown sounce were added to the translations.html.twig so they are not cleaned up. - validation messages, mostly from 3rd party bundles are not cleaned up. - Use TranslatableMessage class in places where translations were not detected before - Cleanup some untranslated and unknown translations
johanib
force-pushed
the
feature/update_jan26
branch
from
4d70e80 to
12ea67e
Compare
johanib
force-pushed
the
feature/update_jan26
branch
from
12ea67e to
73129f9
Compare
Not sure what I can do about that.. acfc0ec shows renamed. But in the diff it interprets it as deleted / added. |
As long as the logs show a rename, we are golden. That should mean we get to keep the git logs 👍 |
Prior to this change, the jms translations bundle was still included. This bundle is no longer maintained, and required the abandoned doctrine/annotations bundle.
This change uses the default symfony translations bundle for managing the translations.
https://symfony.com/doc/current/translation.html