Skip to content

Commit fe6a8f6

Browse files
johanibjohanib
committed
Update translations files to symfony standards
1 parent b6924c7 commit fe6a8f6

8 files changed

Lines changed: 251 additions & 258 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
## Unreleased
4+
- `jms/translation-bundle` is removed. See README.md for up-to-date instructions on updating the translations.
5+
36
## 6.0.0
47
- Upgrade from Symfony 6.4 to Symfony 7.4
58
- Maintenance release, Update tooling, packages

‎README.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ mock service was created for end to end test purposes, but could be utilized in
3636
3. Update the service definition to point to this class: `class: Surfnet\StepupGateway\ApiBundle\Tests\TestDouble\Service\YubikeyService`
3737
4. Do not commit/push this change!
3838

39+
### Translations
40+
Gateway uses the default symfony translations bundle. To extract / update the translations, run:
41+
`./bin/console trans:extract nl_NL --force ; ./bin/console trans:extract en_GB --force`
42+
Then modify and commit the changes.
43+
3944
### Frontend Development
4045

4146
#### Template Preview

‎templates/translations.html.twig‎

Lines changed: 0 additions & 19 deletions
This file was deleted.

‎tests/features/sfo-multiple-authentications.feature‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ Feature: As an institution that uses the second factor only feature
4848
Then the response should match xpath '//samlp:StatusCode[@Value="urn:oasis:names:tc:SAML:2.0:status:Success"]'
4949
When I switch to "Browser tab 1"
5050
Then I enter the expired SMS verification code
51-
And the response should contain 'gateway.form.send_sms_challenge.challenge_expired'
51+
And the response should contain 'Your code has expired. Please request a new code.'
5252

5353
# # Tiqr is not yet functioning in the Behat (smoketest) environment
5454
# Scenario: A regular and SFO authentication in parallel using Tiqr token

‎translations/messages.en_GB.xlf‎

Lines changed: 76 additions & 77 deletions
Large diffs are not rendered by default.

‎translations/messages.nl_NL.xlf‎

Lines changed: 76 additions & 77 deletions
Large diffs are not rendered by default.

‎translations/validators.en_GB.xlf‎

Lines changed: 45 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,163 +1,166 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:jms="urn:jms:translation" version="1.2">
3-
<file date="2018-08-28T16:36:55Z" source-language="en" target-language="en-GB" datatype="plaintext" original="not.available">
2+
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
3+
<file source-language="en-GB" target-language="en-GB" datatype="plaintext" original="file.ext">
44
<header>
5-
<tool tool-id="JMSTranslationBundle" tool-name="JMSTranslationBundle" tool-version="1.1.0-DEV"/>
6-
<note>The source node in most cases contains the sample message as written by the developer. If it looks like a dot-delimitted string such as "form.label.firstname", then the developer has not provided a default message.</note>
5+
<tool tool-id="symfony" tool-name="Symfony"/>
76
</header>
87
<body>
9-
<trans-unit id="d3eed7dad6fb7610f30c9cd66a4a85d0049a7fe7" resname="Key handle must be a string">
8+
<trans-unit id="JnXNpvt" resname="Key handle must be a string">
109
<source>Key handle must be a string</source>
1110
<target>Key handle must be a string</target>
1211
</trans-unit>
13-
<trans-unit id="f355e0c035e0e8362f7611a9930422626e700f74" resname="Register request AppID may not be empty">
12+
<trans-unit id="6WWideO" resname="Register request AppID may not be empty">
1413
<source>Register request AppID may not be empty</source>
1514
<target state="new">Register request AppID may not be empty</target>
1615
</trans-unit>
17-
<trans-unit id="f3906b0e1bebad711e4bba22dd9281fa61146d80" resname="Register request AppID must be a string">
16+
<trans-unit id="a9I76Kw" resname="Register request AppID must be a string">
1817
<source>Register request AppID must be a string</source>
1918
<target state="new">Register request AppID must be a string</target>
2019
</trans-unit>
21-
<trans-unit id="a3f7066aa1d6b17f96feff05f283de5c4165316d" resname="Register request challenge may not be empty">
20+
<trans-unit id="FD_sHCj" resname="Register request challenge may not be empty">
2221
<source>Register request challenge may not be empty</source>
2322
<target state="new">Register request challenge may not be empty</target>
2423
</trans-unit>
25-
<trans-unit id="9537f2c187fa0e1055fe3729127c5e3fe404d035" resname="Register request challenge must be a string">
24+
<trans-unit id="PQW5FHm" resname="Register request challenge must be a string">
2625
<source>Register request challenge must be a string</source>
2726
<target state="new">Register request challenge must be a string</target>
2827
</trans-unit>
29-
<trans-unit id="5f8000a432b5dbbb22737b05b912f394614eaf40" resname="Register request error code may not be empty">
28+
<trans-unit id="a.23PMy" resname="Register request error code may not be empty">
3029
<source>Register request error code may not be empty</source>
3130
<target state="new">Register request error code may not be empty</target>
3231
</trans-unit>
33-
<trans-unit id="34d1187450443fb124755556abf3360597bb7235" resname="Register request error code must be numeric">
32+
<trans-unit id="QnEd7D1" resname="Register request error code must be numeric">
3433
<source>Register request error code must be numeric</source>
3534
<target state="new">Register request error code must be numeric</target>
3635
</trans-unit>
37-
<trans-unit id="1b7093014274b51ad46f81ea7eccd64e76a330ca" resname="Register request version may not be empty">
36+
<trans-unit id="7hBmbO3" resname="Register request version may not be empty">
3837
<source>Register request version may not be empty</source>
3938
<target state="new">Register request version may not be empty</target>
4039
</trans-unit>
41-
<trans-unit id="3b4e7a9012fa48f1769da4f74f487b2e899ce8b7" resname="Register request version must be a string">
40+
<trans-unit id="qLWBtJ2" resname="Register request version must be a string">
4241
<source>Register request version must be a string</source>
4342
<target state="new">Register request version must be a string</target>
4443
</trans-unit>
45-
<trans-unit id="f5516c222dcfc96645a2765479938f0969d3fb24" resname="Sign request AppID may not be empty">
44+
<trans-unit id="dk6tggc" resname="Sign request AppID may not be empty">
4645
<source>Sign request AppID may not be empty</source>
4746
<target state="new">Sign request AppID may not be empty</target>
4847
</trans-unit>
49-
<trans-unit id="cbac0930208f5bb7971822bda488b8c28bcf5e3e" resname="Sign request AppID must be a string">
48+
<trans-unit id="94ed2jH" resname="Sign request AppID must be a string">
5049
<source>Sign request AppID must be a string</source>
5150
<target state="new">Sign request AppID must be a string</target>
5251
</trans-unit>
53-
<trans-unit id="f49116f9b0eb18c71eb7f162161453abee7bd411" resname="Sign request challenge may not be empty">
52+
<trans-unit id="x4Hrfwy" resname="Sign request challenge may not be empty">
5453
<source>Sign request challenge may not be empty</source>
5554
<target state="new">Sign request challenge may not be empty</target>
5655
</trans-unit>
57-
<trans-unit id="1118c1e6f037f7d2fa511d5a2d5fcc36ecfd6146" resname="Sign request challenge must be a string">
56+
<trans-unit id="6l1IP9a" resname="Sign request challenge must be a string">
5857
<source>Sign request challenge must be a string</source>
5958
<target state="new">Sign request challenge must be a string</target>
6059
</trans-unit>
61-
<trans-unit id="165f7d40c1bdff8e1a1d421bc926772e8512eb68" resname="Sign request error code may not be empty">
60+
<trans-unit id="nZrgwjq" resname="Sign request error code may not be empty">
6261
<source>Sign request error code may not be empty</source>
6362
<target state="new">Sign request error code may not be empty</target>
6463
</trans-unit>
65-
<trans-unit id="5edf1a4da208953d8ffae31d1ff5638546dba9cd" resname="Sign request error code must be numeric">
64+
<trans-unit id="hFamHDM" resname="Sign request error code must be numeric">
6665
<source>Sign request error code must be numeric</source>
6766
<target state="new">Sign request error code must be numeric</target>
6867
</trans-unit>
69-
<trans-unit id="82750383d4971841ceacc90807bfaee082d181d1" resname="Sign request key handle may not be empty">
68+
<trans-unit id="_BSHQbe" resname="Sign request key handle may not be empty">
7069
<source>Sign request key handle may not be empty</source>
7170
<target state="new">Sign request key handle may not be empty</target>
7271
</trans-unit>
73-
<trans-unit id="df642ff75bdc48f2e4105c880652486e30efd6fd" resname="Sign request key handle must be a string">
72+
<trans-unit id="ArEcIW7" resname="Sign request key handle must be a string">
7473
<source>Sign request key handle must be a string</source>
7574
<target state="new">Sign request key handle must be a string</target>
7675
</trans-unit>
77-
<trans-unit id="3b20add2755bfe8e1d0562ad9bdb709d83249890" resname="Sign request version may not be empty">
76+
<trans-unit id="tBiHWLJ" resname="Sign request version may not be empty">
7877
<source>Sign request version may not be empty</source>
7978
<target state="new">Sign request version may not be empty</target>
8079
</trans-unit>
81-
<trans-unit id="04ee7b5ea8d828fb35d8e2dee4cdb236aede6d0a" resname="Sign request version must be a string">
80+
<trans-unit id="Ango_uh" resname="Sign request version must be a string">
8281
<source>Sign request version must be a string</source>
8382
<target state="new">Sign request version must be a string</target>
8483
</trans-unit>
85-
<trans-unit id="d7d536e4daf0156dcf5724414c59214bae223843" resname="gateway.verify_yubikey_command.otp.may_not_be_empty">
84+
<trans-unit id="hEU82bL" resname="gateway.verify_yubikey_command.otp.may_not_be_empty">
8685
<source>gateway.verify_yubikey_command.otp.may_not_be_empty</source>
8786
<target>Yubikey field may not be empty.</target>
8887
</trans-unit>
89-
<trans-unit id="74bc02993b9c4ef6e72edd80971c386fae1e2b00" resname="gateway.verify_yubikey_command.otp.must_be_string">
88+
<trans-unit id="oggEQI6" resname="gateway.verify_yubikey_command.otp.must_be_string">
9089
<source>gateway.verify_yubikey_command.otp.must_be_string</source>
9190
<target>Yubikey field must contain a string.</target>
9291
</trans-unit>
93-
<trans-unit id="c47695eb1433ea19b361b7b49bd346bedca0f0d2" resname="otp.value.must_be_set">
92+
<trans-unit id="I.OlDYn" resname="otp.value.must_be_set">
9493
<source>otp.value.must_be_set</source>
9594
<target>The Yubikey OTP must be set.</target>
9695
</trans-unit>
97-
<trans-unit id="ca59d062e8bde4b6a3bcadee1e4e929ee941dea9" resname="otp.value.must_be_string">
96+
<trans-unit id="DMlMjnf" resname="otp.value.must_be_string">
9897
<source>otp.value.must_be_string</source>
9998
<target>The Yubikey OTP must be a string.</target>
10099
</trans-unit>
101-
<trans-unit id="e597d35ab4e8b2fa441d182850c2b690b30f43a5" resname="requester.identity.must_be_set">
100+
<trans-unit id="RCnUJqy" resname="requester.identity.must_be_set">
102101
<source>requester.identity.must_be_set</source>
103102
<target>The requester's identity must be known.</target>
104103
</trans-unit>
105-
<trans-unit id="8f65354b9147294030909054a4dc6e0c24ffc668" resname="requester.identity.must_be_string">
104+
<trans-unit id="Gj6CJGv" resname="requester.identity.must_be_string">
106105
<source>requester.identity.must_be_string</source>
107106
<target>The requester's identity must be a string.</target>
108107
</trans-unit>
109-
<trans-unit id="9f5a1c75a004dcc9b6c61d73855df32fb0b5d80c" resname="requester.institution.must_be_set">
108+
<trans-unit id="TPOXB3o" resname="requester.institution.must_be_set">
110109
<source>requester.institution.must_be_set</source>
111110
<target>The requester's institution must be set.</target>
112111
</trans-unit>
113-
<trans-unit id="08fe42f7aa42b8d84898c5bfbe64c92ecdd313f1" resname="requester.institution.must_be_string">
112+
<trans-unit id="8AJG.jO" resname="requester.institution.must_be_string">
114113
<source>requester.institution.must_be_string</source>
115114
<target>The requester's institution must be a string.</target>
116115
</trans-unit>
117-
<trans-unit id="9993d3622b1b044d2292852cbf2bbc35b25745e0" resname="sms_message.body.must_be_set">
116+
<trans-unit id="Wc_lXUj" resname="sms_message.body.must_be_set">
118117
<source>sms_message.body.must_be_set</source>
119118
<target>The text message body may not be empty.</target>
120119
</trans-unit>
121-
<trans-unit id="57f79eb950d7d7f5ab54c79306b7a625554721d3" resname="sms_message.body.must_be_string">
120+
<trans-unit id="0VKSe38" resname="sms_message.body.must_be_string">
122121
<source>sms_message.body.must_be_string</source>
123122
<target>The text message body must be a string.</target>
124123
</trans-unit>
125-
<trans-unit id="6dc9a4e68657f445f65d37629a2fa4347c0de3d2" resname="sms_message.originator.must_be_alphanumerical">
124+
<trans-unit id="YM8KSM9" resname="sms_message.originator.must_be_alphanumerical">
126125
<source>sms_message.originator.must_be_alphanumerical</source>
127126
<target>The text message originator must be an alphanumerical string.</target>
128127
</trans-unit>
129-
<trans-unit id="3dd48295cc0a76647725bcb96564cdfc7665095e" resname="sms_message.originator.must_be_set">
128+
<trans-unit id="ZujOZZX" resname="sms_message.originator.must_be_set">
130129
<source>sms_message.originator.must_be_set</source>
131130
<target>The text message originator may not be empty.</target>
132131
</trans-unit>
133-
<trans-unit id="eaeee37c955d38f330b87975c891d4b346ae8b62" resname="sms_message.recipient.must_be_set">
132+
<trans-unit id="uCCHOaI" resname="sms_message.recipient.must_be_set">
134133
<source>sms_message.recipient.must_be_set</source>
135134
<target>The text message recipient may not be empty.</target>
136135
</trans-unit>
137-
<trans-unit id="365b549b98686b9cace3ae029d14948f0de5beaf" resname="sms_message.recipient.must_consist_of_numbers">
136+
<trans-unit id="7jq0uQ4" resname="sms_message.recipient.must_consist_of_numbers">
138137
<source>sms_message.recipient.must_consist_of_numbers</source>
139138
<target>The text message recipient may consist only of digits.</target>
140139
</trans-unit>
141-
<trans-unit id="049f2b52bc9cf777280bbfc8b787f6e69a701beb" resname="stepup.send_sms_command.recipient.may_not_be_empty">
140+
<trans-unit id="irHFi_9" resname="stepup.send_sms_command.recipient.may_not_be_empty">
142141
<source>stepup.send_sms_command.recipient.may_not_be_empty</source>
143142
<target state="new">stepup.send_sms_command.recipient.may_not_be_empty</target>
144143
</trans-unit>
145-
<trans-unit id="9e988968acb8506939fa9b6c5d15b6e65cdcdb9f" resname="stepup.send_sms_command.recipient.must_be_string">
144+
<trans-unit id="P6h4z2k" resname="stepup.send_sms_command.recipient.must_be_string">
146145
<source>stepup.send_sms_command.recipient.must_be_string</source>
147146
<target state="new">stepup.send_sms_command.recipient.must_be_string</target>
148147
</trans-unit>
149-
<trans-unit id="f40a78148c674a1d7961ef7ca5d048664caf70b7" resname="stepup.send_sms_command.recipient.must_consist_of_digits">
148+
<trans-unit id="fkeOeYB" resname="stepup.send_sms_command.recipient.must_consist_of_digits">
150149
<source>stepup.send_sms_command.recipient.must_consist_of_digits</source>
151150
<target state="new">stepup.send_sms_command.recipient.must_consist_of_digits</target>
152151
</trans-unit>
153-
<trans-unit id="b7bcb89ad4b6ed61daa138541702c67ce7dd63c9" resname="stepup.verify_possession_of_phone_command.challenge.may_not_be_empty">
152+
<trans-unit id="5Qah_Ax" resname="stepup.verify_possession_of_phone_command.challenge.may_not_be_empty">
154153
<source>stepup.verify_possession_of_phone_command.challenge.may_not_be_empty</source>
155154
<target state="new">stepup.verify_possession_of_phone_command.challenge.may_not_be_empty</target>
156155
</trans-unit>
157-
<trans-unit id="8b87f20ba80c487ed07070e32d031343571d34b9" resname="stepup.verify_possession_of_phone_command.challenge.must_be_string">
156+
<trans-unit id="L_xz.SB" resname="stepup.verify_possession_of_phone_command.challenge.must_be_string">
158157
<source>stepup.verify_possession_of_phone_command.challenge.must_be_string</source>
159158
<target state="new">stepup.verify_possession_of_phone_command.challenge.must_be_string</target>
160159
</trans-unit>
160+
<trans-unit id="B9r0Hn5" resname="Error">
161+
<source>Error</source>
162+
<target>Error</target>
163+
</trans-unit>
161164
</body>
162165
</file>
163166
</xliff>

0 commit comments

Comments
 (0)