-
Notifications
You must be signed in to change notification settings - Fork 1
Add precompile interfaces for Multi-Constraint Pricer #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
gligneul
reviewed
Oct 17, 2025
7b1e927
to
96ed82d
Compare
gligneul
approved these changes
Oct 17, 2025
gligneul
requested changes
Oct 17, 2025
gligneul
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eljobe
requested changes
Oct 21, 2025
gligneul
approved these changes
Oct 21, 2025
eljobe
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of NIT-4021
Add Multi-Constraint Pricer methods:
getGasPricingConstraints
toArbGasInfo
to fetch constraints as an array of triples (gas_target_per_second, time_constant_seconds, backlog)setGasPricingConstraints
toArbOwner
to set constraints as an array of triples (gas target, time constraint, starting_backlog_value)