Skip to content

Conversation

@MishkaRogachev
Copy link

Part of NIT-4021

Depends on OffchainLabs/nitro-precompile-interfaces#19
Nitro PR: OffchainLabs/nitro#3860

Update the nitro-precompiles-interfaces submodule.

@MishkaRogachev
Copy link
Author

There are same formatter issue on the CI, but I'm not sure if it's worth to update it just for submodule

@gligneul gligneul removed their assignment Oct 21, 2025
@MishkaRogachev MishkaRogachev force-pushed the add-precompiles-for-multi-constraint-pricer branch from 77f6de0 to 777e334 Compare October 21, 2025 14:58
gligneul
gligneul previously approved these changes Oct 21, 2025
eljobe
eljobe previously approved these changes Oct 22, 2025
@MishkaRogachev MishkaRogachev dismissed stale reviews from eljobe and gligneul via 863120a October 22, 2025 09:19
@MishkaRogachev MishkaRogachev force-pushed the add-precompiles-for-multi-constraint-pricer branch from 777e334 to 863120a Compare October 22, 2025 09:19
@MishkaRogachev MishkaRogachev changed the base branch from main to develop October 22, 2025 09:19
gligneul
gligneul previously approved these changes Oct 22, 2025
eljobe
eljobe previously approved these changes Oct 22, 2025
@MishkaRogachev
Copy link
Author

Formatter fix: OffchainLabs/nitro-precompile-interfaces#21

@MishkaRogachev MishkaRogachev dismissed stale reviews from eljobe and gligneul via 5f9cb1e October 22, 2025 12:31
@MishkaRogachev MishkaRogachev force-pushed the add-precompiles-for-multi-constraint-pricer branch from 863120a to 5f9cb1e Compare October 22, 2025 12:31
gligneul
gligneul previously approved these changes Oct 22, 2025
@eljobe
Copy link
Member

eljobe commented Oct 23, 2025

I'm seeing what looks like it might be a legitimate failure. Assigning back to @MishkaRogachev

@eljobe eljobe assigned MishkaRogachev and unassigned eljobe Oct 23, 2025
@MishkaRogachev MishkaRogachev marked this pull request as draft October 23, 2025 17:28
@MishkaRogachev MishkaRogachev force-pushed the add-precompiles-for-multi-constraint-pricer branch from 5f9cb1e to e67196c Compare October 24, 2025 11:18
@MishkaRogachev MishkaRogachev marked this pull request as ready for review October 24, 2025 11:59
@MishkaRogachev MishkaRogachev requested a review from eljobe October 24, 2025 11:59
@eljobe eljobe merged commit 7c95e8b into develop Oct 24, 2025
12 checks passed
@eljobe eljobe deleted the add-precompiles-for-multi-constraint-pricer branch October 24, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants