Skip to content

Fix #1518: Add additional check in IsMinimalEndpoint to prevent false positives #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #1518: Add additional check in IsMinimalEndpoint to prevent false positives #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Microsoft.AspNetCore.OData/Extensions/HttpContextExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using System.Reflection;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Routing;
using Microsoft.AspNetCore.OData.Abstracts;
using Microsoft.AspNetCore.OData.Edm;
using Microsoft.AspNetCore.OData.Formatter;
Expand Down Expand Up @@ -97,7 +98,8 @@ internal static bool IsMinimalEndpoint(this HttpContext httpContext)

// Check if the endpoint is a minimal endpoint.
var endpoint = httpContext.GetEndpoint();
return endpoint?.Metadata.GetMetadata<ODataMiniMetadata>() != null;
return endpoint?.Metadata.GetMetadata<HttpMethodAttribute>() == null
&& endpoint?.Metadata.GetMetadata<ODataMiniMetadata>() != null;
}

internal static IEdmModel GetOrCreateEdmModel(this HttpContext httpContext, Type clrType, ParameterInfo parameter = null)
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.AspNetCore.OData.E2E.Tests/DollarSearch/DollarSearchDataModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class SearchProduct

public SearchCategory Category { get; set; }

public List<SearchTag> Tags { get; set; }�// List of tags
public List<SearchTag> Tags { get; set; } // List of tags
}

public class SearchCategory
Expand Down