Fix #1518: Add additional check in IsMinimalEndpoint to prevent false positives #1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…false positives When Minimal Apis are not used, and controllers are, ODataQueryOptions<TEntity> always calls PopulateMetadata, which will always add metadata of type ODataMiniMetadata to the endpoint. Currently, when IsMinimalEndpoint is called, it checks whether ODataMiniMetadata exists which is always the case. This commits makes it additionally check for an HttpMethodAttribute in the endpoint metadata.
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Minimal Apis are not used, and controllers are,
ODataQueryOptions<TEntity>always callsPopulateMetadata(), which will always add metadata of typeODataMiniMetadatato the endpoint.Currently, when
httpContext.IsMinimalEndpoint()is called, it checks whetherODataMiniMetadataexists which is always the case.This commits makes it additionally check for an
HttpMethodAttributein the endpoint metadata.Additionally, when
PopulateMetadata()was called, the endpointBuilder.Metadata list was empty, so it was not possible to check for other attributes.