Skip to content

[16.0][IMP] l10n_jp_summary_invoice: Add the report to the chatter attachments while printing the report #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nobuQuartile wants to merge 1 commit into
base: 16.0
Choose a base branch
from
+4 −0
Open

[16.0][IMP] l10n_jp_summary_invoice: Add the report to the chatter attachments while printing the report #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions l10n_jp_summary_invoice/reports/summary_invoice_reports.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
<field name="report_file">l10n_jp_summary_invoice.report_summary_invoice</field>
<field name="binding_model_id" ref="account_billing.model_account_billing" />
<field name="binding_type">report</field>
<field name="attachment_use">True</field>
Copy link
Member

@yostashiro yostashiro Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably causes more confusion if we download from the attachment.

Suggested change
<field name="attachment_use">True</field>

<field
name="attachment"
>(object.state == 'posted') and ('Summary Invoice-%s' % (object.name))</field>
Copy link
Member

@yostashiro yostashiro Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>(object.state == 'posted') and ('Summary Invoice-%s' % (object.name))</field>
>(object.state == 'billed') and ('Summary Invoice-%s' % (object.name))</field>

Please check if assigning date+time attaches the document at every print action. I think the best is to be able to assign a revision number (e.g., _r1, r2...) but I don't have a good idea how to implement this quickly at the moment.

<field
name="print_report_name"
>'Summary Invoice-%s%s' % (object.name, object.state == 'draft' and '-draft' or '')</field>
Expand Down