Skip to content

Conversation

@nobuQuartile
Copy link
Contributor

  • Enabled attachment_use and defined attachment to store generated reports as PDF files in the chatter when the document state is 'posted'.
  • While not a full implementation, conceptually aligns with Japan's Electronic Books Maintenance Act by storing finalized PDF reports in the chatter.

@qrtl QT5504

@nobuQuartile nobuQuartile force-pushed the 16.0-imp-l10n_jp_summary_invoice branch from 1849ce6 to 9ca5c8a Compare August 25, 2025 05:40
@nobuQuartile nobuQuartile changed the title [16.0][IMP] l10n_jp_summary_invoice: Add the report to the chatter attachments when printing the report [16.0][IMP] l10n_jp_summary_invoice: Add the report to the chatter attachments while printing the report Aug 25, 2025
…nts while printing the report

- Enabled `attachment_use` and defined `attachment` to store generated
  reports as PDF files in the chatter when the document state is 'posted'.
- While not a full implementation, conceptually aligns with Japan's
  Electronic Books Maintenance Act by storing finalized PDF reports
  in the chatter.
@nobuQuartile nobuQuartile force-pushed the 16.0-imp-l10n_jp_summary_invoice branch from 9ca5c8a to 181acfa Compare August 25, 2025 06:59
<field name="report_file">l10n_jp_summary_invoice.report_summary_invoice</field>
<field name="binding_model_id" ref="account_billing.model_account_billing" />
<field name="binding_type">report</field>
<field name="attachment_use">True</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably causes more confusion if we download from the attachment.

Suggested change
<field name="attachment_use">True</field>

<field name="attachment_use">True</field>
<field
name="attachment"
>(object.state == 'posted') and ('Summary Invoice-%s' % (object.name))</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>(object.state == 'posted') and ('Summary Invoice-%s' % (object.name))</field>
>(object.state == 'billed') and ('Summary Invoice-%s' % (object.name))</field>

Please check if assigning date+time attaches the document at every print action. I think the best is to be able to assign a revision number (e.g., _r1, r2...) but I don't have a good idea how to implement this quickly at the moment.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants