Skip to content

python3Packages.json-schema-for-humans: 0.27.1 -> 0.31.0#115114

Closed
fabaff wants to merge 4 commits intoNixOS:masterfrom
fabaff:pyre
Closed

python3Packages.json-schema-for-humans: 0.27.1 -> 0.31.0#115114
fabaff wants to merge 4 commits intoNixOS:masterfrom
fabaff:pyre

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Mar 4, 2021 •
edited
Loading

Motivation for this change

Update to latest upstream release 0.31.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners March 4, 2021 18:13
@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 4, 2021
@fabaff fabaff marked this pull request as draft March 4, 2021 18:18
@fabaff

This comment has been minimized.

Sign in to view
@ofborg ofborg bot requested a review from ruuda March 4, 2021 18:22
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 4, 2021
@r-rmcgibbo

This comment has been minimized.

Sign in to view
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 5, 2021

Why is this a draft?

@fabaff
Copy link
Member Author

fabaff commented Mar 5, 2021

Because it would be nice if the package builds for Python 3.9.

@ofborg ofborg bot requested review from albakham and ruuda March 6, 2021 08:22
@fabaff fabaff force-pushed the pyre branch 2 times, most recently from 1186fed to 87938cb Compare March 6, 2021 09:10
@fabaff

This comment has been minimized.

Sign in to view
@ofborg ofborg bot requested a review from SuperSandro2000 March 6, 2021 10:40
@fabaff
Copy link
Member Author

fabaff commented Mar 6, 2021

Down to 19 packages which are following the same pattern.

SuperSandro2000
SuperSandro2000 reviewed Mar 7, 2021
View reviewed changes
pkgs/development/python-modules/typing-inspect/default.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Mar 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we apply this unconditionally?

Copy link
Member Author

@fabaff fabaff Mar 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. I saw failures if the patch is applied to Python 3.7/3.8. Let me test again.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 7, 2021

Down to 19 packages which are following the same pattern.

Which pattern?

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 7, 2021
@fabaff fabaff changed the title python3Packages.libcst: 0.3.13 -> 0.3.17 python3Packages.json-schema-for-humans: 0.27.1 -> 0.31.0 Mar 7, 2021
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 7, 2021
@ofborg ofborg bot requested a review from astro March 7, 2021 09:06
@fabaff
Copy link
Member Author

fabaff commented Mar 7, 2021

Which pattern?

  preCheck = ''
    # directory shadows imports
    rm -r google
[...]

and the builds failed because the google directory was no longer present. Doesn't seems to be an issue on staging-next.

@fabaff fabaff marked this pull request as ready for review March 7, 2021 10:33
@risicle
Copy link
Contributor

risicle commented Mar 14, 2021 •
edited
Loading

Is that what's causing the libcst breakage?

@fabaff
Copy link
Member Author

fabaff commented Mar 15, 2021

Is that what's causing the libcst breakage?

That's something else

[...]
  File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/subprocess.py", line 340, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/subprocess.py", line 1706, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'isort'
builder for '/nix/store/42h608fmbjf61ymaq87rxvgmz0y73pj3-python3.8-libcst-0.3.17.drv' failed with exit code 1

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 16, 2021

@fabaff please resolve the merge conflict.

@fabaff
Copy link
Member Author

fabaff commented Mar 16, 2021

@fabaff please resolve the merge conflict.

Done

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2021
@fabaff

This comment has been minimized.

Sign in to view
@fabaff

This comment has been minimized.

Sign in to view
@ofborg ofborg bot requested a review from SuperSandro2000 March 23, 2021 20:01
@fabaff

This comment has been minimized.

Sign in to view
@fabaff
Copy link
Member Author

fabaff commented Mar 24, 2021

It looks like that the failing packages are executing pytestCheckPhase twice.

  ===================== 1219 passed, 100 warnings in 14.97s ======================
  Finished executing pytestCheckPhase
  pytestcachePhase
  pytestCheckPhase
  Executing pytestCheckPhase
  rm: cannot remove 'google': No such file or directory

@fabaff fabaff force-pushed the pyre branch 2 times, most recently from 89db764 to 4053c81 Compare April 23, 2021 11:26
SuperSandro2000
SuperSandro2000 reviewed Apr 24, 2021
View reviewed changes
@fabaff fabaff mentioned this pull request May 5, 2021
Closed
10 tasks
@fabaff
Copy link
Member Author

fabaff commented May 5, 2021

Result of nixpkgs-review pr 115114 run on x86_64-linux 1

60 packages failed to build:
  • dvc-with-remotes
  • python38Packages.google-cloud-asset
  • python38Packages.google-cloud-automl
  • python38Packages.google-cloud-bigquery
  • python38Packages.google-cloud-bigquery-datatransfer
  • python38Packages.google-cloud-container
  • python38Packages.google-cloud-dataproc
  • python38Packages.google-cloud-datastore
  • python38Packages.google-cloud-dlp
  • python38Packages.google-cloud-error-reporting
  • python38Packages.google-cloud-iam
  • python38Packages.google-cloud-iot
  • python38Packages.google-cloud-kms
  • python38Packages.google-cloud-language
  • python38Packages.google-cloud-monitoring
  • python38Packages.google-cloud-os-config
  • python38Packages.google-cloud-pubsub
  • python38Packages.google-cloud-redis
  • python38Packages.google-cloud-secret-manager
  • python38Packages.google-cloud-securitycenter
  • python38Packages.google-cloud-spanner
  • python38Packages.google-cloud-speech
  • python38Packages.google-cloud-storage
  • python38Packages.google-cloud-tasks
  • python38Packages.google-cloud-texttospeech
  • python38Packages.google-cloud-translate
  • python38Packages.google-cloud-vision
  • python38Packages.google-cloud-websecurityscanner
  • python38Packages.hypothesmith
  • python38Packages.libcst
  • python39Packages.google-cloud-asset
  • python39Packages.google-cloud-automl
  • python39Packages.google-cloud-bigquery
  • python39Packages.google-cloud-bigquery-datatransfer
  • python39Packages.google-cloud-container
  • python39Packages.google-cloud-dataproc
  • python39Packages.google-cloud-datastore
  • python39Packages.google-cloud-dlp
  • python39Packages.google-cloud-error-reporting
  • python39Packages.google-cloud-iam
  • python39Packages.google-cloud-iot
  • python39Packages.google-cloud-kms
  • python39Packages.google-cloud-language
  • python39Packages.google-cloud-monitoring
  • python39Packages.google-cloud-os-config
  • python39Packages.google-cloud-pubsub
  • python39Packages.google-cloud-redis
  • python39Packages.google-cloud-secret-manager
  • python39Packages.google-cloud-securitycenter
  • python39Packages.google-cloud-spanner
  • python39Packages.google-cloud-speech
  • python39Packages.google-cloud-storage
  • python39Packages.google-cloud-tasks
  • python39Packages.google-cloud-texttospeech
  • python39Packages.google-cloud-translate
  • python39Packages.google-cloud-vision
  • python39Packages.google-cloud-websecurityscanner
  • python39Packages.hypothesmith
  • python39Packages.libcst
  • wal_e
7 packages built:
  • json-schema-for-humans (python38Packages.json-schema-for-humans)
  • python38Packages.dataclasses-json
  • python38Packages.typing-inspect
  • python39Packages.dataclasses-json
  • python39Packages.json-schema-for-humans
  • python39Packages.typing-inspect
  • sublime-music

@ofborg ofborg bot requested a review from SuperSandro2000 May 5, 2021 20:24
@fabaff
Copy link
Member Author

fabaff commented Jun 6, 2021

Superseded by #126015

@fabaff fabaff closed this Jun 6, 2021
@fabaff fabaff mentioned this pull request Jun 6, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@ruuda ruuda Awaiting requested review from ruuda

@albakham albakham Awaiting requested review from albakham

@astro astro Awaiting requested review from astro

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fabaff @r-rmcgibbo @SuperSandro2000 @risicle @ruuda