Skip to content

python3Packages.datclasses-json: 0.5.2 -> 0.5.3#121821

Closed
sumnerevans wants to merge 3 commits intoNixOS:masterfrom
sumnerevans:dataclasses-json-0.5.3
Closed

python3Packages.datclasses-json: 0.5.2 -> 0.5.3#121821
sumnerevans wants to merge 3 commits intoNixOS:masterfrom
sumnerevans:dataclasses-json-0.5.3

Conversation

@sumnerevans
Copy link
Contributor

@sumnerevans sumnerevans commented May 5, 2021

Motivation for this change

https://github.com/lidatong/dataclasses-json/releases/tag/v0.5.3

Also converts to build from source and run the tests from upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 5, 2021
@ofborg ofborg bot requested a review from albakham May 5, 2021 17:59
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 5, 2021
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label May 5, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 5, 2021

Result of nixpkgs-review pr 121821 at 5ced668 run on aarch64-linux 1

2 packages marked as broken and skipped:
  • python39Packages.dataclasses-json
  • python39Packages.json-schema-for-humans
3 packages built successfully:
  • json-schema-for-humans (python38Packages.json-schema-for-humans)
  • python38Packages.dataclasses-json
  • sublime-music
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/dataclasses-json/default.nix:25:0:

       |
    25 |     description = "Simple API for encoding and decoding dataclasses to and from JSON";
       | ^
    

Result of nixpkgs-review pr 121821 at 5ced668 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python39Packages.dataclasses-json
  • python39Packages.json-schema-for-humans
3 packages built successfully:
  • json-schema-for-humans (python38Packages.json-schema-for-humans)
  • python38Packages.dataclasses-json
  • sublime-music
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/development/python-modules/dataclasses-json/default.nix:25:0:

       |
    25 |     description = "Simple API for encoding and decoding dataclasses to and from JSON";
       | ^
    

marshmallow-enum
];

checkInputs = with python3Packages; [
Copy link
Member

@fabaff fabaff May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests would be enabled with 4053c81 in #115114.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks! I'll make this a draft until that gets merged in and I'll rebase off of your changes.

@sumnerevans sumnerevans marked this pull request as draft May 5, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants