Set version to 25.3.0-rc.1

[jgehrcke]

We decided that we want to make a release candidate for the upcoming release at first.

Note that as of https://helm.sh/docs/topics/charts/#the-chartyaml-file the version field in a Helm chart YAML is required to be semver-compliant, and a v prefix isn't allowed: https://semver.org/#is-v123-a-semantic-version.

For simplicity, we keep the appVersion field the same (although it doesn't have the same strict constraint).

Edit: no, give appVersion a "v" prefix again because it populates the default value for the image tag at

k8s-dra-driver-gpu/deployments/helm/nvidia-dra-driver-gpu/values.yaml

Line 43 in 8d34f97

tag: ""

.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[jgehrcke]

In the Makefile, my assumption is that we want to keep the v prefix, and also our git tag strategy will continue to use the v prefix.

Edit: looking at vVERSION below this VERSION here is meant to not have a v prefix.

In hacks/prepare-helm-release.sh we rely on VERSION to not have a v prefix.

edit: new approach: don't consume vVERSION, conditionally v-strip VERSION in context of Helm.

[elezar]

https://github.com/NVIDIA/k8s-device-plugin/blob/f171c9269279c5021b286c9a7ca9a428bb673bea/hack/package-helm-charts.sh#L25

Pull Request Overview

This PR updates the Helm chart version to a release candidate by removing the invalid "v" prefix and appending "-rc.1" to both the version and appVersion fields. The changes ensure the Chart.yaml complies with semver for the version field while synchronizing appVersion with the new release candidate value.

• Updated version field in Chart.yaml from "v25.3.0" to "25.3.0-rc.1"
• Updated appVersion field in Chart.yaml from "v25.3.0" to "25.3.0-rc.1"

[jgehrcke]

Kevin stated via Slack

the container image should still have the v

This change ensures we use the v prefix here (for the image).

[elezar]

It's not quite as simple as that ...
the SHA-tagged images shouldn't have a v prefix.

[jgehrcke]

SHA-tagged images shouldn't have a v prefix.

Okay. That means we must not set IMAGE_VERSION := $(vVERSION).

We could do

IMAGE_VERSION := $(git rev-parse --short=8)

instead in case of CI. But my intuition is that we don't like this change.

We have a new package-helm-charts.sh in here that always wants a version w/o v prefix:

k8s-dra-driver-gpu/hack/package-helm-charts.sh

Line 25 in 8d34f97

VERSION=${VERSION}

So, I will revert the IMAGE_VERSION change and amend package-helm-charts.sh to conditionally strip a v prefix from VERSION.

[jgehrcke]

Done the above.

[klueska]

You will also need to make appropriate changes in:

deployments/helm/nvidia-dra-driver-gpu/Chart.yaml

[jgehrcke]

$ varx="v25.3.0"; varx="${varx#v}"; echo $varx
25.3.0


$ varx="bc"; varx="${varx#a}"; echo $varx
bc

[jgehrcke]

Thanks for reviews. Incorporated the feedback and squashed into a single commit.

[jgehrcke]

@ArangoGutierrez had another important remark, as of which appVersion must have the v prefix. I amended the patch and once again force-pushed. @ArangoGutierrez Thank you. With your approval we should now move ahead and try this out (and see where it breaks). :)

[jgehrcke]

This revealed a number of interesting insights and inter-dependencies.

The various constraints could be met with a different implementation. The current patch is just one way to do things. We can iterate in the future. (for example, appVersion could also not be v-prefixed and then we could add the `v in the calculation, to just name one of many different methods).

If this contains further mistakes (because arguably, things got complex and are difficult to check pre-merge) then we will reveal that during the actual release process.

Feeling OK about the current state. Thanks for reviews, merging.